Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow TinyMCE to respect the template's options #14456

Closed
wants to merge 4 commits into from
Closed

Allow TinyMCE to respect the template's options #14456

wants to merge 4 commits into from

Conversation

dgrammatiko
Copy link
Contributor

Pull Request for improving the UX and making editing a bit easier.

Summary of Changes

TinyMCE out of the box comes with some very basic styling. Eg the Bold button is just a <strong> around the selected text. But the editor gives the ability for further customisations e.g.: attach a class or inline styles etc...

So this PR brings that functionality to Joomla.
It covers both styles and formats (styles are the ones that correspond to the buttons e.g. bold, align left, etc and formats are the ones that will be in the formats dropdown)

Testing Instructions

Grab the files from https://gist.github.com/dgt41/be9e16814371f43ce99e8dc74ef54e99
and place them in administrator/templates/isis/css directory
Edit tinyMCE's configuration and type the relative paths:
screen shot 2017-03-10 at 13 09 07
Edit an article and observe the code when selecting a format or applying a style (e.g. bold, align right)
screen shot 2017-03-10 at 12 42 49

Expected result

Styles (standard buttons):

screen shot 2017-03-10 at 13 14 35

Formats (Formats dropdown

screen shot 2017-03-10 at 13 14 03
):

Documentation Changes Required

Yup!

Inspired by @coolcat-creations post on @brianteeman 's site...

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels Mar 10, 2017
@brianteeman
Copy link
Contributor

From your screenshot you show the file being a json file

The language strings make no mention of this at all

@dgrammatiko
Copy link
Contributor Author

@brianteeman you can improve it as you like...

@brianteeman
Copy link
Contributor

@DGT41 but I dont know what it should be

@dgrammatiko
Copy link
Contributor Author

The filename could be anything, same goes for the path, the only requirement is to be json type.

@brianteeman
Copy link
Contributor

the only requirement is to be json type

So that needs to be mentioned ;)

@infograf768
Copy link
Member

maybe with ahint in the field?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14456.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants