Fix for: Field subform (multiple) produces wrong id #16480
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #15187 .
Summary of Changes
The pull fix the way how the script calculate the id for a fields and it's labels.
Also now it should be more close to
JFormField::getId
result.Testing Instructions
For test can use next XML (place it in some params form,eg in template or custom module):
Expected result
After add "new row", check the input/labels id, they should be similar to screenshot:
![screen 2017-06-03 17 18 02 936x245](https://cloud.githubusercontent.com/assets/1568198/26754423/4ecef51a-4883-11e7-8c08-b3f8aafcdb5c.png)
Actual result
ID of the labels is not fixed,
they contain
X
eg:..._subform__subformX_..
Documentation Changes Required
none