Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Correct wrong tag "base" to "head" in templates/system/incompatible.html #18796

Merged
merged 1 commit into from
Nov 22, 2017

Conversation

richard67
Copy link
Member

Pull Request for no issue.

Summary of Changes

In templates/system/incompatible.html, "base" tag is used instead of "head".

This error comes from PR #18777.

Testing Instructions

Code review.

Expected result

Correct HTML.

Actual result

Incorrect HTML.

Documentation Changes Required

None.

@richard67
Copy link
Member Author

richard67 commented Nov 22, 2017

@DGT41 @wilsonge Please check. Code style errors reported by Drone and Travis are not relate to this PR here.

@mbabker mbabker merged commit 85fd8c2 into joomla:4.0-dev Nov 22, 2017
@richard67
Copy link
Member Author

@mbabker Wow, that was fast. Thanks.

@richard67 richard67 deleted the patch-2 branch November 22, 2017 18:47
@zero-24 zero-24 added this to the Joomla 4.0 milestone Nov 22, 2017
@dgrammatiko
Copy link
Contributor

@richard67 thanks, I'll blame emmet here

@richard67
Copy link
Member Author

@DGT41 Was obvious when looking at the diff of the file ... what people always should do with their PRs ... and again do the guy who merges it ... so I would not only blame emmet here but 2 more people.

@dgrammatiko
Copy link
Contributor

🤪

laoneo pushed a commit to Digital-Peak/joomla-cms that referenced this pull request Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants