Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain filtered month in archive form #19391

Merged
merged 1 commit into from
Jan 18, 2018
Merged

Retain filtered month in archive form #19391

merged 1 commit into from
Jan 18, 2018

Conversation

Quy
Copy link
Contributor

@Quy Quy commented Jan 17, 2018

This is a partial fix for Issue #19382.

Summary of Changes

In the Archive search form, the month dropdown has leading zero from Jan. to Sep.

<select id="month" name="month" size="1" class="inputbox">
	<option value="">Month</option>
	<option value="01">Jan</option>
	<option value="02">Feb</option>
	<option value="03">Mar</option>
	<option value="04">Apr</option>
	<option value="05">May</option>
	<option value="06">Jun</option>
	<option value="07">Jul</option>
	<option value="08">Aug</option>
	<option value="09">Sep</option>
	<option value="10">Oct</option>
	<option value="11">Nov</option>
	<option value="12">Dec</option>
</select>

This PR removes the leading zero to match the month query string so the chosen month is selected:
http://localhost/joomla-cms-staging/archived-articles/2011?view=archive&month=1

Testing Instructions

Install demo.
Click Archive link.
Click January, 2011.
In the archive form, see the month dropdown.

Expected result

Jan is selected.

Actual result

Month is selected.

Documentation Changes Required

none

@Quy Quy changed the title Retain selected month in archive form Retain filter month in archive form Jan 17, 2018
@Quy Quy changed the title Retain filter month in archive form Retain filtered month in archive form Jan 17, 2018
@ghost
Copy link

ghost commented Jan 17, 2018

I have tested this item ✅ successfully on a7e550d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19391.

@alikon
Copy link
Contributor

alikon commented Jan 17, 2018

I have tested this item ✅ successfully on a7e550d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19391.

@ghost
Copy link

ghost commented Jan 17, 2018

Ready to Commit after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 17, 2018
@mbabker mbabker added this to the Joomla 3.8.4 milestone Jan 18, 2018
@mbabker mbabker merged commit 8a70590 into joomla:staging Jan 18, 2018
@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC This Pull Request is Ready To Commit labels Jan 18, 2018
@Quy Quy deleted the patch-13 branch January 18, 2018 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants