-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert routing changes in 3.8.4 #19512
Conversation
This reverts commit 128a4d4.
… with association enabled (joomla#19295)" This reverts commit 5994eb1.
…)" This reverts commit 05fd1d9.
… menu item (joomla#19099)" This reverts commit d068868.
Works fine. Evidently, #15730 is still an issue if no login form menu item is present. |
I have tested this item ✅ successfully on 335100c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19512. |
I have tested this item ✅ successfully on 335100c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19512. |
@mbabker to decide |
Will look later when back from travel.
As the saying goes, stuff happens. Nobody's blaming you. |
I have created a PR to, at least, inform users of the necessity to create a login form when Home is set to registered. #19535 |
Thanks |
Good work, your not to blame. You PR was valid, the issue is the lack of people testing the 3.8.4 release. |
Ready to Commit after two successful tests. |
Installed 3.8.5 on 67 websites and everything seems fine. Great work. I wanted to compliment the development team on the work since Joomla 3 was released. Along with the Gantry Framework team, you have cut my maintenance time by at least 10% on websites. That's extra time for the golf course. :) |
Pull Request for Issue #19504
Summary of Changes
Because I am responsible for this, I feel that I have to prepare a reverse PR.
I'm not a fan of this PR but I won't insist to stay without reversion.
Each of reverted PRs are connected each other.
Expected result
The same as on 3.8.3
Actual result
New structured URLs.