Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Fix invalid table names in assocations #21171

Merged
merged 1 commit into from
Jul 18, 2018
Merged

Conversation

wilsonge
Copy link
Contributor

Pull Request for Issue #21110

Summary of Changes

Fixes the table names

Testing Instructions

See #21110 - no longer errors

@wilsonge wilsonge requested a review from laoneo July 18, 2018 10:33
@wilsonge wilsonge changed the title Fix invalid table names in assocations [4.0] Fix invalid table names in assocations Jul 18, 2018
@ghost
Copy link

ghost commented Jul 18, 2018

I have tested this item ✅ successfully on bb3443a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21171.

@infograf768
Copy link
Member

I do not have the Notices anymore (Nice) but some weird behavior in the side by side page.

here is a screenshot for 2 articles (Already associated)
screen shot 2018-07-18 at 13 10 18

Here for 2 contacts.
remark the tabs are changed to buttons (that may be a template issue) but also the fact that the association is not displayed which is a bug.
screen shot 2018-07-18 at 13 12 20

@ghost
Copy link

ghost commented Jul 18, 2018

have seen Buttons but thought out of Scope of this PR.

@wilsonge
Copy link
Contributor Author

The tabs collapse into an accordion style format on smaller screen resolutions. so i think that's good.

@wilsonge wilsonge merged commit 89d65ba into 4.0-dev Jul 18, 2018
@wilsonge
Copy link
Contributor Author

Merging this to allow progress. Most of the rest of the issues are javascript ones which aren't my strong suit :P

@wilsonge wilsonge deleted the fix/assocations branch July 18, 2018 12:34
@wilsonge wilsonge added this to the Joomla 4.0 milestone Jul 18, 2018
@wilsonge
Copy link
Contributor Author

@infograf768 fwiw

screen shot 2018-07-18 at 18 08 49

Right now in dev the association doesn't display either - so I don't think that's a 4.x bug

The change target button is broken in 4.x though - I've asked Dimitris to look into that

@infograf768
Copy link
Member

Right now in dev the association doesn't display either

you mean in 3.x ?

@infograf768
Copy link
Member

The tabs collapse into an accordion style format on smaller screen resolutions. so i think that's good.

no problem with that. The issue is that we have a different display for menu items, articles and caregories.

@wilsonge
Copy link
Contributor Author

wilsonge commented Jul 18, 2018

you mean in 3.x ?

Yes (see screenshot)

no problem with that. The issue is that we have a different display for menu items, articles and caregories.

I think @DGT41 implemented the custom element tabs in articles and categories only right now (also media manager - but obviously that's not covered by associations) - so I'd expect those two to be different to the rest right now. That's a WIP that will get standardised one way or another

@infograf768
Copy link
Member

you mean in 3.x ?

Yes (see screenshot)

GRRR, same for newsfeeds.... We have to solve that. Also in 3.x

@infograf768
Copy link
Member

Created issue
#21178

@infograf768
Copy link
Member

and patch for 3.x
#21180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants