[4.0] Upgrade php-stemmer 2.0 #27568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactoring stemmer integration by reducing the seperated classes and using the stemmer factory to create a stemmer object. This reduces maintenance because no change in Joomla! is required to support new languages added by the upstream php-stemmer class and we reduce complexity in Joomla! code base.
|
Did you mean to delete all those files? |
|
Yes they are not longer needed. |
|
thanks for the clarification |
mbabker
reviewed
Jan 19, 2020
|
I have tested this item ✅ successfully on a2e5c36 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27568. |
|
Thx for the text but I will change the exception later but shouldn't effect your test. |
wilsonge
reviewed
Jan 21, 2020
wilsonge
reviewed
Jan 21, 2020
wilsonge
reviewed
Jan 21, 2020
|
Thanks! |
brianteeman
pushed a commit
to brianteeman/joomla-cms
that referenced
this pull request
Feb 4, 2020
Refactoring stemmer integration by reducing the seperated classes and using the stemmer factory to create a stemmer object. This reduces maintenance because no change in Joomla! is required to support new languages added by the upstream php-stemmer class and we reduce complexity in Joomla! code base.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #27329 .
Summary of Changes
Upgrade php-stemmer from version 1.2 to 2.0, refactoring stemmer class to use stemmer factory.
Testing Instructions
Use smart search with different languages and content.
Expected result
Nothing changes.
Actual result
Everything still works.