Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Remove coloring from icons #30415

Merged
merged 1 commit into from
Aug 19, 2020
Merged

[4.0] Remove coloring from icons #30415

merged 1 commit into from
Aug 19, 2020

Conversation

SharkyKZ
Copy link
Contributor

@SharkyKZ SharkyKZ commented Aug 19, 2020

Summary of Changes

Removes explicit colors from these two icons.

Testing Instructions

node build.js --compile-css required.

Add some icons somewhere. E.g.:

<span class="icon-featured"></span>
<span class="icon-search"></span>
<span class="icon-publish"></span>
<span class="icon-unpublish"></span>

Actual result BEFORE applying this Pull Request

icon-publish and icon-unpublish are invisible against white background.

Expected result AFTER applying this Pull Request

Icons are same color.

Documentation Changes Required

No.

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Aug 19, 2020
@infograf768
Copy link
Member

infograf768 commented Aug 19, 2020

Can you post a screenshot of where it would show?
Asking because I just did 2 PRs concerning icons colors.

@SharkyKZ
Copy link
Contributor Author

Anywhere. This just makes that publish/unpublish icons get their color from text like any other icon.

@Quy
Copy link
Contributor

Quy commented Aug 19, 2020

I have tested this item ✅ successfully on 82809cf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30415.

1 similar comment
@infograf768
Copy link
Member

I have tested this item ✅ successfully on 82809cf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30415.

@infograf768 infograf768 removed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Aug 19, 2020
@infograf768
Copy link
Member

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30415.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 19, 2020
@Quy Quy added this to the Joomla 4.0 milestone Aug 19, 2020
@Quy Quy merged commit d876d06 into joomla:4.0-dev Aug 19, 2020
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester and removed RTC This Pull Request is Ready To Commit labels Aug 19, 2020
@SharkyKZ SharkyKZ deleted the j4/scss/icons branch August 19, 2020 17:14
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants