Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s/compatability/compatibility #32781

Closed
wants to merge 1 commit into from
Closed

s/compatability/compatibility #32781

wants to merge 1 commit into from

Conversation

PhilETaylor
Copy link
Contributor

s/compatability/compatibility

@PhilETaylor

This comment was marked as abuse.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 9bf6767

Code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32781.

@SharkyKZ
Copy link
Contributor

I have tested this item 🔴 unsuccessfully on 9bf6767

Code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32781.

@PhilETaylor

This comment was marked as abuse.

@Quy
Copy link
Contributor

Quy commented Mar 21, 2021

It is my understanding that files in vendor directory should be made upstream and then migrated downstream.

@PhilETaylor

This comment was marked as abuse.

@PhilETaylor

This comment was marked as abuse.

@richard67
Copy link
Member

Last time this file was fetched from the framework was in 2019 or earlier. This commit in the framework hasn't arrived in the CMS yet: joomla-framework/application@134f298 .

But that's the only difference between the CMS and the framework version.

So here it could indeed make sense to do the change in the framework and later pull it into the CMS.

We have other framework stuff were we have more differences between framework and CMS, like e.g. database, and where we changed things in the CMS and later pulled it up into the framework, and I thought that's the case here, too, that's why I haven't insisted in doing it upstream in the framework.

All that said only for J3 (staging, 3.10-dev). For J4 it's definitely different.

@PhilETaylor

This comment was marked as abuse.

@richard67
Copy link
Member

See also joomla-framework/application#94 and joomla-framework/application#95 ... we gotta pull the changes from the framework as soon as the PR's there got merged.

Thanks @PhilETaylor for reporting and making the PR's there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants