[4.0] Redo the com_templates

[dgrammatiko]

Pull Request for Issue # .

Summary of Changes

One view to rule them all.

• Removes the 2 different entry layouts for the templates (template, style)
• Introduces the styling from Konshu template
• Fixes all the menus
• Brings the install logic from Konshu

This PR largely is the adoption of the work that was done by @kawshar and his team in their backend template. So all the kudos should go to them, I'm just bringing their code to the current branch (with their permissions)

Testing Instructions

This is part of a wider rewrite of com_templates, probably has some a11y issues but should be functionally on par with the previous state (actually should be better as everything is one click away)

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Install template with one click

Documentation Changes Required

@brianteeman can you review the a11y and the strings here?

[brianteeman]

looks good. will test properly later

[Quy]

Go to Home Dashboard.
Click Cog icon under Site and select Edit.
Remove Template Code Icon option.

[dgrammatiko]

@Quy done, thanks, good catch

[Bond97]

I dont know, should I create new issue, but I write my suggestion in this PR.

When I upgrade Joomla 4.0.0 beta8-dev to new daily version (check updates and reinstall Joomla core files), sometimes there is a notification "%number% overriden files changed" and in this frame text changed to "%number% overrides to check".

I go to administrator/index.php?option=com_templates&view=templates, in override files column show yellow "changes found". Usually it happens with helixultimate template (new 2.0.0 beta version). With cassiopeia that notification not showing.

My suggestion: show, which of files has changed or overriden. Maybe it be useful for @dgrammatiko attempt to rewrite com_template.

Or it's unnecessary function?

[brianteeman]

The main change I would make is the way that multiple styles of the same template are handled.

In khansu they were all listed together but in this version they duplicate all the other template stuff.

Plus the preview is for the style not the template. So I would be looking to make the layout more like

[brianteeman]

My suggestion: show, which of files has changed or overriden.

And if there are 25 changed files?

[dgrammatiko]

Plus the preview is for the style not the template. So I would be looking to make the layout more like

That was easy

In khansu they were all listed together but in this version they duplicate all the other template stuff.

This needs some query tweaking

[Bond97]

@brianteeman I don't know about that, it's just my suggestion :) I think, when number of changed files are more than 15-20, it's hard to read list all of them.

Maybe it's unnesessary function.

[brianteeman]

@dgrammatiko I think you also need to rethink the actions menu - it might not even be needed - so that its clear if the action is for the style or the template

[ceford]

Looks good. The Title bar might be Templates: Site or Templates Administrator as required. I think the default template should no be 'deletable'. And I guess the double icons for Info and Preview will get fixed. The first screen grab shows a different side menu order - I assume that is a user choice and not an intended default (no need to answer that unless it is).

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32896.}

[kawshar]

Why don't you use the exact UX that we proposed?

[dgrammatiko]

@kawshar I think I kept it almost intact (apart from changing some elements for a11y and using the existing styling, not going to restyle everything here)

[ceford]

Another thought: I wonder if Edit Files and Edit Style might be simplified to Files and Options? For me the word Style leads me to expect to do something with css but that is done by editing user.css.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32896.}

[brianteeman]

@ceford that does indeed make sense when you only have one style. As soon as you have multiple styles it becomes more confusing.

[brianteeman]

do you really need this?

[RickR2H]

@dgrammatiko let me know if I can help test the feature! 😉

[dgrammatiko]

@RickR2H it's not fully functional atm (it creates just the html dir structure in the template) but if you have some time and test the front end and give some feedback that would be valuable

[dgrammatiko]

Sneak preview of template duplication/Child template creation

[chmst]

It was my dream since I am using Joomla to have the two template views in one, thanks for working on that.

But I have a few remarks and think ithat the appearance should be consistent with atum.

• In the menu an Icon-arrow-down stands for installation when on all other places atum uses icon-upload
• A select list where I expect options for selection is not a select list but kind information bubble
• What means the word Legacy here?
• A cog the actions dropdown (@brianteeman uses another coq for that withour dropdown arrow)
• Icons for actions are not unique (delete = uninstall, fork = new)
• h3 tag for "styles" is a rupture in the structure (a11y).
• would be nice to have the same behaviour of the default icon as in other lists.

[dgrammatiko]

But I have a few remarks and think ithat the appearance should be consistent with atum.

Generally speaking, this is still WIP so things will eventually be more consistent

A select list where I expect options for selection is not a select list but kind information bubble

There are 2 commands there: send email to support and get the template description

What means the word Legacy here?

Legacy is referring to the templates that CANNOT have child templates, Modern will be the ones that do support them

h3 tag for "styles" is a rupture in the structure (a11y).

The card footer is not really representative of what will be there finally, it needs work

would be nice to have the same behaviour of the default icon as in other lists.

There's a star icon that is supposed to do that, the logic is missing atm

About all the icons, I just picked random ones but it's an easy task to change them

[dgrammatiko]

This one could be revisited in v5

[brianteeman]

@dgrammatiko please re-open this. Dont allow yourself to be bullied by ignorant fools (unless of course they were correct and you were paid to mess joomla up as claimed on tiwtter)

[dgrammatiko]

@brianteeman this is replaced by

• 4.1 Child templates 1/2 #35874
• [4.1] Child templates 2/2 [clean] #35998
• [4.1] TinyMCE changes for child templates 3/3  #36011

for 4.1 according to the maintainers' guidance. This can still be valid for another release.
I'm currently trying to finish the missing part (the file editing portion) but I saw your comment #35911 (comment) and I'm trying to figure a way to satisfy the a11y needs. It would be helpful if I wasn't triggered earlier by someone that doesn't understand that the web evolves and new features cannot always be introduced without B/C breaks. Also unfortunately I haven't been paid, but even if someone offered money for some unethical coding I wouldn't accept it. Maybe that's the reason I'm not rich...

[rinka88]

I know this thread is closed. But I would like to know whether such a view will be implemented in the next versions?
(Since version 5 is coming)

[dgrammatiko]

@rinka88 I can only say that I'm not working on this anymore (and nobody asked me to do so), for anything related to v5 you have to ask @HLeithner

[rinka88]

it would be a pity if such good things were lost. And you can not offer them in the form of pr?

[dgrammatiko]

And you can not offer them in the form of pr?

I'm afraid this is not the right way, let me explain: finishing this PR means I have to personally spend many man-hours coding/styling/testing/etc with a huge uncertainty if the PR will ever get merged (if not it was just wasted time). I cannot afford to dedicate the needed time right now, but even I was able to do so, I wouldn't do that before the maintainers gave me a clear signal that this work won't be ignored/turned down...

Anyways, September is a very busy month for me and I think after September there's no reasonable time to make this happen. Maybe in 5.1 or later (if people are not too attached to b/c breaks within a single component) and there is a competent release leader...