[4.1] TinyMCE changes for child templates 3/3 #36000
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgrammatiko
force-pushed
the
4.1-dev-tinyMCE-Editor-CSS
branch
from
d47b024 to
f794d99
Compare
Quy
reviewed
Nov 10, 2021
|
replaced by #36011 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
HTMLHelper::includeRelativeFilesto accept the template as an objectHTMLHelper::image,HTMLHelper::stylesheetandHTMLHelper::scriptto accept the template as an object in the optionsgetTemplate()in the apps to also have the client_id in the returned objectHTMLHelper::stylesheetin the tinyMCE for theeditor.css(solves also the .min bug)Testing Instructions
Apply the patch in the current 4.1
Verify that the editor.css is loading as expected
Apply #35874 and then this PR
Verify that the editor.css is loading as expected
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
No debug:
With debug enabled:
Documentation Changes Required
The changes ARE B/C, nothing is breaking here. The concept of passing the template as an object to the 3 helper functions means that we don't have to replicate the existing relative loading procedure in the tinyMCE (maybe it would be helpful for other scenarios)
@bembelimen @laoneo @wilsonge could you guys review this one?