[4.1] Fix wrong sequence next values in PostgreSQL installation SQL scripts #37154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@richard67 This looks good to me. |
This was referenced Feb 26, 2022
|
I have tested this item ✅ successfully on 6187512 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37154. |
|
I have tested this item ✅ successfully on 6187512 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37154. |
richard67
changed the title
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37154. |
1 similar comment
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37154. |
|
Thanks! |
richard67
deleted the
4.1-dev-fix-wrong-sequence-next-value-for-postgresql
branch
|
@wilsonge Do you think it could need some update SQL script to fix wrong sequences on update? |
|
I'm not sure. Obviously in an ideal world yes - but given it affects all existing sites not sure whether it's going to cause more pain that it's worth? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
This pull request (PR) fixes the next sequence values in PostgreSQL installation SQL scripts which have been forgotten to change when new records for the task scheduler were added with PR #35143 .
Some more wrong values from that PR e.g. for the assets table have already been fixed by someone with some other PR.
Testing Instructions
Code review by someone who knows how sequences work on PostgreSQL, or make a new installation using a PostgreSQL database and then try to insert new records into tables "#__action_logs_extensions" or "#__action_log_config".
Actual result BEFORE applying this Pull Request
Inserting a new record fails with error about duplicate primary key, e.g.:
Expected result AFTER applying this Pull Request
Inserting a new record works, and the new ID has the right value.
Documentation Changes Required
None.