-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate inline help toggle button to com_config component Options view (see #35610) #37158
Conversation
branch is out of date so not able to test it |
you can use the Prebuilt package |
I have tested this item ✅ successfully on 80c2f8a As for com_content and other components, we will need to go through their Options pages with a fine comb to see which options need to be documented and how. But as you said that't the subject of another PR :) This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37158. |
Testing with my own extension, and working perfectly (even including your inlinehelp button in my edit view works well!)
So, should i enable it in all core components in this PR, or wait inlinehelp review for each component, and enable option when review is complete ? |
@cyrezdev Regarding this:
If you read the original PR (#35610), namely the “Why make this change” you will see why this is not going to happen. You already figure it out yourself.
Yup. That's why. Ideally, we'd need real user testing to know if the assumption that beginners will click that button is true or if we need to revise. Fat chance of that happening. The next best thing I could do is deploy support of Show Inline Help to my security software which has an infamously extensive configuration page. The past ~9 years it had tooltips. Now it has Show Inline Help. Within a few short months I will know if Show Inline Help works for inexperienced users. Until then, I am not fighting this battle no more! :D
Leave this PR as is. If it gets RTC and we get official word it's getting merged you can do a new PR for all other core components and then we can then work on PRs for the help strings of each component (one per component) — the latter will need additional review from native English speakers to ensure clarity and conciseness. |
I have tested this item ✅ successfully on 80c2f8a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37158. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37158. |
Thx |
Pull Request to extend PR #35610.
cc/ @nikosdion
Summary of Changes
Testing Instructions
Actual result BEFORE applying this Pull Request
No inline help toggle button in com_content options.
Expected result AFTER applying this Pull Request
Toggle button to show/hide inline help in com_content options.
Documentation Changes Required
To integrate inline help toggle button in any component (core + third party), add the following line in your config.xml file for components. (after element)
<inlinehelp button="show" targetclass=""/>
Params: