[4.2] fix admin module popular

[heelc29]

Summary of Changes

Add created_by to list select query to get article items.

The created_by property is required if the core.edit permission is not allowed. Function was added with #36559.

joomla-cms/administrator/modules/mod_popular/src/Helper/PopularHelper.php

Lines 88 to 91 in e9b9263

	if (
	$user->authorise('core.edit', 'com_content.article.' . $item->id)
	|| ($user->authorise('core.edit.own', 'com_content.article.' . $item->id) && ($userId === $item->created_by))
	) {

Testing Instructions

Check the admin dashboard with a user with these permissions on com_content:

Actual result BEFORE applying this Pull Request

PHP Warning: Undefined property: stdClass::$created_by in [ROOT]\administrator\modules\mod_popular\src\Helper\PopularHelper.php on line 90

Expected result AFTER applying this Pull Request

Link to edit own article is displayed (and no PHP warning)

Link to documentations

Please select:

• No documentation changes for docs.joomla.org needed
• No documentation changes for manual.joomla.org needed

[carlitorweb]

I have tested this item ✅ successfully on 59956eb

Note: For get the right permission the test require, is enough with create a user under Author group and add the "Access Administration Access" from the global configuration permissions.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39482.}

[ReLater]

I have tested this item ✅ successfully on 59956eb

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39482.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39482.}

[wilsonge]

Thanks!