-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] Error handling while create folder in media manager new pr #39878
Conversation
@dgrammatiko please hint me how this error handling posisble for online storage solution |
You need to ask @laoneo for this, I'm not well educated on this |
We should not have duplicate folder name validation on the server and client side. So all the client should do is to handle the error properly which comes from the server. |
@laoneo but at current stage backend show msg error occured for all validation failure cases that can handle by this pr
|
Then you need to fix the server side to return proper errors. |
yes that can also done but this will increase number of clicks by user .Best way that I got it to show error in modal by @dgrammatiko and from issue #39263 . |
This pull request has been automatically rebased to 4.4-dev. |
This pull request has been automatically rebased to 5.2-dev. |
I have tested this item ✅ successfully on b1e5105 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39878. |
I have tested this item ✅ successfully on b1e5105 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39878. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39878. |
Thank you! |
joomla/joomla-cms#44658 + joomla/joomla-cms#44712 - (только для др. пакетов) joomla/joomla-cms#39878 + joomla/joomla-cms#38536 + joomla/joomla-cms#36719 + joomla/joomla-cms#44753 + joomla/joomla-cms#44709 + joomla/joomla-cms#44793 - (только для en-GB)
Pull Request for Issue #39263
Alternate pr of pr #39793
Summary of Changes
Handling error while create folder by checking enter name by user
Testing Instructions
create folder and try create a folder by input invalid name
Actual result BEFORE applying this Pull Request
php error and create folder modal is open
Expected result AFTER applying this Pull Request
afoldername.mp4
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed