Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Invalid usage of static methods #41666

Merged
merged 7 commits into from
Sep 12, 2024

Conversation

Denitz
Copy link
Contributor

@Denitz Denitz commented Sep 8, 2023

Summary of Changes

Static methods should be not called in object context.

Testing Instructions

Apply patch.

Actual result BEFORE applying this Pull Request

See IDE warnings.

Expected result AFTER applying this Pull Request

No IDE warnings.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Sorry, something went wrong.

@HLeithner
Copy link
Member

need some tests here please

@HLeithner HLeithner changed the title 5.0 Invalid usage of static methods [5.0] Invalid usage of static methods Sep 12, 2023
@HLeithner HLeithner changed the base branch from 5.0-dev to 5.1-dev September 30, 2023 22:48
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.1-dev.

@Denitz Denitz changed the title [5.0] Invalid usage of static methods [5.1] Invalid usage of static methods Oct 3, 2023
@HLeithner HLeithner changed the base branch from 5.1-dev to 5.2-dev April 24, 2024 09:07
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.2-dev.

@HLeithner HLeithner changed the title [5.1] Invalid usage of static methods [5.2] Invalid usage of static methods Apr 24, 2024
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.3-dev.

@HLeithner HLeithner changed the base branch from 5.2-dev to 5.3-dev September 2, 2024 08:52
@HLeithner HLeithner changed the title [5.2] Invalid usage of static methods [5.3] Invalid usage of static methods Sep 2, 2024
@Hackwar Hackwar changed the base branch from 5.3-dev to 5.2-dev September 3, 2024 11:02
@Hackwar Hackwar changed the title [5.3] Invalid usage of static methods [5.2] Invalid usage of static methods Sep 3, 2024
@Hackwar Hackwar added the bug label Sep 3, 2024
@Hackwar
Copy link
Member

Hackwar commented Sep 12, 2024

Thank your for your contribution @Denitz!

@Hackwar Hackwar added this to the Joomla! 5.2.0 milestone Sep 12, 2024
@Hackwar Hackwar enabled auto-merge (squash) September 12, 2024 10:25
@Hackwar Hackwar merged commit 2a7dbe6 into joomla:5.2-dev Sep 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants