-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Updates the dependencies #42945
Conversation
I had done a seperate update PR for tinymce to raise awareness as there were a lot of changes - but i can close it |
The same applies to my PR #42937 - it's included in this one here so can be closed when this one here is merged. |
Hmm, when checking for deleted files and folders with this PR, I get a lot from web-token. Here the output of my tool:
It seems they have restructured their folders somehow. And when checking what remains in folders names like "jwt-signature-algorithm-something", I just see developer stuff which we should not ship with our installations, or should we? Each of these folders contains a LICENSE and a README.md file, a ".github" folder and a "composer.json" file. So maybe we should delete that stuff in the "build/build.php" from the package folder like we do it with other developer-only stuff, and if we do that, the list of deleted files and folders would be even longer. |
On a deeper look it seems we got an experimental version of that web-token stuff. In the composer.lock it resolves to Maybe we can update to a stable version instead of experimental? |
Or maybe that "experimental" is only a naming thing. For me this PR here is ok, just the release managers should not forget that I have to make one for the deleted files and folders after this got merged. |
Thank you @laoneo |
Updates the dependencies without major versions. Removed the strict vue version.
The data collector had a variable which needs to be public, otherwise you will get a compilation error.
Did run the following commands: