Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Finder: Simplifying the populateState() method of SearchModel #43091

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Mar 19, 2024

Pull Request for Issue #43087 .

Summary of Changes

For reasons unobvious to me, we are using the data from the request object in our input object when populating the state of the SearchModel model. This PR changes this to be in line with all other models by simply using the input object.

Testing Instructions

Codereview?

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Sorry, something went wrong.

@growunder
Copy link

Code reviewed, seams ok


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43091.

@LadySolveig LadySolveig changed the base branch from 5.1-dev to 5.2-dev July 3, 2024 13:30
@LadySolveig LadySolveig changed the title [5.1] Finder: Simplifying the populateState() method of SearchModel [5.2] Finder: Simplifying the populateState() method of SearchModel Jul 3, 2024
@HLeithner
Copy link
Member

I would expect the reason is that you can simple use POST or GET requests for the search, now only GET is possible anymore?

@Fedik
Copy link
Member

Fedik commented Jul 15, 2024

now only GET is possible anymore?

Nope, it the same, $input contain whole data from $_REQUEST, so it will be same result as $input->request.

For only GET would be $input->get->get('foobar'),
For only POST would be $input->post->get('foobar'),

@laoneo laoneo enabled auto-merge (squash) August 14, 2024 09:07
@laoneo laoneo added this to the Joomla! 5.2.0 milestone Aug 14, 2024
@laoneo laoneo merged commit d27d512 into joomla:5.2-dev Aug 14, 2024
3 of 4 checks passed
@laoneo
Copy link
Member

laoneo commented Aug 14, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants