-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing variable to light theme #43117
Add missing variable to light theme #43117
Conversation
Yes it should. I dont know why people decide to use different classes for same things all over the backend. That makes things really hard. :-) |
I would fix the markup to use the correct class rather than the css |
Ok then I need a decision if this should be a btn-secondary or in all other views a btn-info |
I did an additional PR for the markup #43120 |
I have tested this item ✅ successfully on 2d367a0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43117. |
1 similar comment
I have tested this item ✅ successfully on 2d367a0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43117. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43117. |
Thanks! |
Pull Request for Issue # .
Summary of Changes
Add missing variable in light mode
Actual result BEFORE applying this Pull Request
Before this PR

Expected result AFTER applying this Pull Request