Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Merge update parameter and improve contrain checker #43147

Merged
merged 13 commits into from
Mar 27, 2024

Conversation

bembelimen
Copy link
Contributor

Pull Request for Issue #43100 .

Summary of Changes

With TUF testing channel is not needed anymore and should use the TUF behaviour. Also allow now explicit testing for "default" and "next"

Testing Instructions

  • Install Beta 1
  • Apply patch to beta 1
  • Go to joomla updater
  • Go to options and select "default" + "beta" for stability level
  • Update

Actual result BEFORE applying this Pull Request

Options not there, update does not work

Expected result AFTER applying this Pull Request

Update works

@brianteeman
Copy link
Contributor

Should the code comments here be updated to include "testing"

* The commented "case" below are for documenting where 'default' and legacy options falls

@MacJoom
Copy link
Contributor

MacJoom commented Mar 26, 2024

I have tested this item ✅ successfully on ea1b3fb

From a 5.1 Beta 1 Installation. Without the patch i have the message 'This site can't be updated to Joomla 5.1.0-beta2 .... doesn't meet the minimum requirements...' - with the patch it works!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43147.

@dautrich
Copy link

dautrich commented Mar 26, 2024

I have tested this item ✅ successfully on ea1b3fb

Same behavior as described by @MacJoom


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43147.

@richard67
Copy link
Member

RTC as this PR has 2 successful human tests. But it needs more fixes for the updater when using TUF. E.g. the channel ("5.x" or "6.x" depending on Default or Next update source) currently is currently not checked, as far as I can see, and there is one more place where we should use the minimumStability parameter independently from the selected update channel as suggested with my PR for this PR.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43147.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 26, 2024
@MacJoom
Copy link
Contributor

MacJoom commented Mar 26, 2024

I have tested both "default" and "next" channel. With the patch it works as expected for both channels. It gives different messages depending on the channel set. "next" channel offers the update to 5.1 beta 2.

@joomla-cms-bot joomla-cms-bot added the Language Change This is for Translators label Mar 27, 2024
@LadySolveig LadySolveig merged commit a9950a7 into joomla:5.1-dev Mar 27, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 27, 2024
@LadySolveig
Copy link
Contributor

Thank you @bembelimen and for support to @richard67 and also for testing @MacJoom and @dautrich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants