-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Merge update parameter and improve contrain checker #43147
Conversation
Should the code comments here be updated to include "testing"
|
I have tested this item ✅ successfully on ea1b3fb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43147. |
I have tested this item ✅ successfully on ea1b3fb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43147. |
RTC as this PR has 2 successful human tests. But it needs more fixes for the updater when using TUF. E.g. the channel ("5.x" or "6.x" depending on Default or Next update source) currently is currently not checked, as far as I can see, and there is one more place where we should use the minimumStability parameter independently from the selected update channel as suggested with my PR for this PR. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43147. |
I have tested both "default" and "next" channel. With the patch it works as expected for both channels. It gives different messages depending on the channel set. "next" channel offers the update to 5.1 beta 2. |
Thank you @bembelimen and for support to @richard67 and also for testing @MacJoom and @dautrich |
joomla/joomla-cms#42966 - (только для en-GB) joomla/joomla-cms#42953 + joomla/joomla-cms#42986 + joomla/joomla-cms#42221 + joomla/joomla-cms#41659 + joomla/joomla-cms#43061 + joomla/joomla-cms#43054 - (только для en-GB) joomla/joomla-cms#42995 - (только для en-GB) joomla/joomla-cms#43115 + joomla/joomla-cms#43147 + + Upmerge
Pull Request for Issue #43100 .
Summary of Changes
With TUF testing channel is not needed anymore and should use the TUF behaviour. Also allow now explicit testing for "default" and "next"
Testing Instructions
Actual result BEFORE applying this Pull Request
Options not there, update does not work
Expected result AFTER applying this Pull Request
Update works