[5.2] Fixing typehint for getListQuery to QueryInterface #43265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quy
reviewed
Apr 12, 2024
Quy
reviewed
Apr 12, 2024
Quy
reviewed
Apr 12, 2024
administrator/components/com_privacy/src/Model/RequestsModel.php
Outdated
Show resolved
Hide resolved
Quy
reviewed
Apr 12, 2024
administrator/components/com_privacy/src/Model/ConsentsModel.php
Outdated
Show resolved
Hide resolved
Quy
reviewed
Apr 12, 2024
Quy
reviewed
Apr 12, 2024
rdeutz
approved these changes
Apr 18, 2024
pe7er
reviewed
Apr 23, 2024
pe7er
reviewed
Apr 23, 2024
pe7er
reviewed
Apr 23, 2024
pe7er
reviewed
Apr 23, 2024
|
Thanks @Hackwar ! |
heelc29
added a commit
to heelc29/joomla-cms
that referenced
this pull request
Oct 6, 2024
dgrammatiko
pushed a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Oct 17, 2024
* Fixing typehint for getListQuery to QueryInterface * Missed 2 things * Updating docblock comments * docblock fixes
pe7er
pushed a commit
that referenced
this pull request
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The database object in Joomla returns an object implementing QueryInterface, but all our docblocks for getListQuery claim it is a DatabaseQuery object. This PR unifies this to use the QueryInterface everywhere. This set of changes is the result of a run of phpstan on our codebase.
Testing Instructions
Codereview.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed