Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Refactor all instances of File to use framework #43362

Merged
merged 17 commits into from
Aug 26, 2024

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Apr 24, 2024

Summary of Changes

We are in the process of migrating away from the CMS filesystem package to use the framework version of it. This PR converts all remaining instances where File is used to use the framework version.

Testing Instructions

Test that you can install extensions and that you can update Joomla.

OR

Codereview.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Fedik Fedik added the Feature label Apr 26, 2024
richard67 and others added 4 commits May 29, 2024 19:13
…nto 5.2-filesystem-file

# Conflicts:
#	administrator/components/com_installer/src/Model/InstallModel.php
#	administrator/components/com_joomlaupdate/src/Model/UpdateModel.php
@Fedik
Copy link
Member

Fedik commented Aug 15, 2024

@Hackwar a hint for debuging, hack the ErroDocument, and set status 200

The thing that cypress always show blank page when the response code non 200.
This hack will force it to render joomla error page (unless it handled by Symfony error handler), and see them on screen shots in Artifacts.

@Hackwar
Copy link
Member Author

Hackwar commented Aug 15, 2024

The problem is, that we are surpressing the error page by having debug mode disabled. And in API there is no error page.

@Fedik
Copy link
Member

Fedik commented Aug 15, 2024

that we are surpressing the error page by having debug mode disabled

Yes, but you still will not see error on screenshot, because response non 200.

And in API there is no error page.

hmhm, yea, that tricky

@Hackwar Hackwar force-pushed the 5.2-filesystem-file branch from 482c9b3 to 5a95c15 Compare August 15, 2024 12:11
@degobbis
Copy link
Contributor

I have tested this item ✅ successfully on 16a0a1e

Installing and uninstalling works as expected


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43362.

@exlemor
Copy link

exlemor commented Aug 24, 2024

I have tested this item ✅ successfully on 16a0a1e

I was able to install 4-5 simple to large components and confirmed they worked and uninstalled them successfully.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43362.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43362.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 24, 2024
@Hackwar Hackwar removed the RTC This Pull Request is Ready To Commit label Aug 25, 2024
@Hackwar
Copy link
Member Author

Hackwar commented Aug 25, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43362.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 25, 2024
@pe7er pe7er removed the Feature label Aug 26, 2024
@pe7er pe7er enabled auto-merge (squash) August 26, 2024 10:00
@pe7er pe7er self-assigned this Aug 26, 2024
@pe7er pe7er merged commit 9833057 into joomla:5.2-dev Aug 26, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 26, 2024
@Hackwar Hackwar deleted the 5.2-filesystem-file branch August 26, 2024 10:34
@pe7er pe7er added this to the Joomla! 5.2.0 milestone Aug 26, 2024
@pe7er
Copy link
Contributor

pe7er commented Aug 26, 2024

Thanks @Hackwar !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants