-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] Refactor all instances of File to use framework #43362
Conversation
administrator/components/com_joomlaupdate/src/Model/UpdateModel.php
Outdated
Show resolved
Hide resolved
…nto 5.2-filesystem-file # Conflicts: # administrator/components/com_installer/src/Model/InstallModel.php # administrator/components/com_joomlaupdate/src/Model/UpdateModel.php
administrator/components/com_joomlaupdate/src/Model/UpdateModel.php
Outdated
Show resolved
Hide resolved
@Hackwar a hint for debuging, hack the ErroDocument, and set status 200
The thing that cypress always show blank page when the response code non 200. |
The problem is, that we are surpressing the error page by having debug mode disabled. And in API there is no error page. |
Yes, but you still will not see error on screenshot, because response non 200.
hmhm, yea, that tricky |
482c9b3
to
5a95c15
Compare
I have tested this item ✅ successfully on 16a0a1e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43362. |
I have tested this item ✅ successfully on 16a0a1e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43362. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43362. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43362. |
Thanks @Hackwar ! |
Summary of Changes
We are in the process of migrating away from the CMS filesystem package to use the framework version of it. This PR converts all remaining instances where File is used to use the framework version.
Testing Instructions
Test that you can install extensions and that you can update Joomla.
OR
Codereview.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed