Replace at feature in SessionManagerTest unit test #43381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
This does not resolve the reported issue. "phpunit it out of date and unsupported" |
|
I want to do it in two steps, one to fix the test and when this is done update the phpunit version |
|
thats perfect and expected but you shoujldnt have closed the issue until both are done |
|
Thanks! |
dgrammatiko
pushed a commit
to dgrammatiko/joomla-cms
that referenced
this pull request
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #42528 .
Summary of Changes
Remove the at() function because it is deprecated for phpunit10.
Site note: Can be discussed if the test has make sense in the past, here I only made it run.
Testing Instructions
run the unit test e.g. phpunit --testdox --filter SessionManagerTest
Actual result BEFORE applying this Pull Request
deprecated messages for the test
Expected result AFTER applying this Pull Request
no deprecated messages for the test
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed