Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the button text used when selecting a content template from "Save" to "Insert".
No additional changes are required for this to be translated as "Insert" is already translated.
(This PR was created at the request of "Daniel C K Tan" on facebook.
Testing Instructions
If you dont already have content templates set up and working for tinymce go to the plugin settings for tinymce and setup the correct folder
Then create a .txt file in that folder. (As this is just to test the UI the file can be empty)
Finaly in an article select the content template icon from the toolbar
And in the dialog that opens observe the text of the buttons.
Then apply this PR and retest. As it is a js change either apply the pr and then run
npm i
or use the prebuilt joomla package that can be found at the bottom of this page at the download linkActual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed