Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2][Events] Class for MailBeforeRendering event #43529

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented May 25, 2024

Summary of Changes

Add an event class for forgoten event onMailBeforeRendering

Testing Instructions

In global configuration push "Send Test Mail" button.

Actual result BEFORE applying this Pull Request

Email sent without error

Expected result AFTER applying this Pull Request

Email sent without error

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org: TBD
  • No documentation changes for manual.joomla.org needed

Sorry, something went wrong.

@Fedik Fedik added Feature Small A PR which only has a small change labels May 25, 2024
 Conflicts:
	libraries/src/Mail/MailTemplate.php
@crommie
Copy link

crommie commented Aug 24, 2024

I have tested this item ✅ successfully on c1ca9b2

No errors, all seems to work.

But: I'm working on a PBF server website. I didn't receive the Test e-mail so I'm not sure it all still works (yes, I did change the global email address). Since I didn't receive it before as well as after I think it might have something to do with something server-related.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43529.

@TLWebdesign
Copy link

I have tested this item ✅ successfully on c1ca9b2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43529.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43529.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 24, 2024
@Hackwar Hackwar enabled auto-merge (squash) August 26, 2024 05:36
@Hackwar
Copy link
Member

Hackwar commented Aug 26, 2024

Thanks for your contribution!

@Hackwar Hackwar added this to the Joomla! 5.2.0 milestone Aug 26, 2024
@Hackwar Hackwar merged commit 321b153 into joomla:5.2-dev Aug 26, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 26, 2024
@Fedik Fedik deleted the event-mail-template branch August 26, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature PR-5.2-dev Small A PR which only has a small change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants