Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Usability: Back-end - Add total number of items to Page Navigation #43570

Closed
wants to merge 4 commits into from

Conversation

brianteeman
Copy link
Contributor

Pull Request for Issue ##43548 .

Summary of Changes

Adds the total number of items at the end of a table

image

The total will be present on any list view that uses <?php echo $this->pagination->getListFooter(); ?>

Testing Instructions

Apply PR and check the bottom of the table
Make sure that the total is correct after filters have been applied
Make sure that the total is displayed even when the pagination is not applied

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@HLeithner
Copy link
Member

if you already introduce a new line, wouldn't it make sense to also show the current item position something like:
1 - 20 / 60 items

Language string would be something like this:

JLIB_HTML_PAGINATION_ITEMS="%1$d - %2$d / %3$d items"

@brianteeman
Copy link
Contributor Author

That was not part of the feature request

@HLeithner
Copy link
Member

You are right I created an alternative implementation #43575

@brianteeman
Copy link
Contributor Author

Note that both this implementation and the alternative are not completely correct when it comes to accessibility. The information should really be in the caption element

@@ -483,6 +483,7 @@ JGLOBAL_INHERIT="Inherit"
JGLOBAL_INTEGRATION_LABEL="Integration"
JGLOBAL_INTRO_TEXT="Intro Text"
JGLOBAL_ISFREESOFTWARE="%s is free software released under the <a href=\"https://www.gnu.org/licenses/gpl-2.0.html\" target=\"_blank\" rel=\"noopener noreferrer\">GNU General Public License</a>."
JGLOBAL_ITEM_COUNT="%d Items"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to handle when there is only one item.

@brianteeman
Copy link
Contributor Author

Closing this in favour of #43575

@brianteeman brianteeman deleted the items branch May 30, 2024 20:22
@pe7er
Copy link
Contributor

pe7er commented Jun 3, 2024

Thanks @brianteeman !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators PR-5.2-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants