Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2][Events] Use event classes for Media-action plugins #43608

Merged
merged 6 commits into from
Aug 29, 2024

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Jun 3, 2024

Pull Request for Issue # .

Summary of Changes

Update media-action plugins to use SubscriberInterface and event classes.

Testing Instructions

Edit image in Media manager, try to crop and rotate it.

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org: New Event classes Manual#177
  • No documentation changes for manual.joomla.org needed

@exlemor
Copy link

exlemor commented Jul 23, 2024

I have tested this item ✅ successfully on eb24b35

I have tested that the behavior before and after the plugin being activated is the same.

That said, while it behaves the SAME with or WITHOUT the plugin, the Media Manager is doing weird stuff.

I crop and rotate an image which is shown as cropped and rotated in the Media Manager(and also shown correctly cropped/rotated via Preview in the media manager) but when I import the image into my article, it is uncropped and original orientation ?!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43608.

@brianteeman
Copy link
Contributor

I crop and rotate an image which is shown as cropped and rotated in the Media Manager(and also shown correctly cropped/rotated via Preview in the media manager) but when I import the image into my article, it is uncropped and original orientation ?!

Did you save

@fgsw
Copy link

fgsw commented Aug 15, 2024

I have tested this item ✅ successfully on eb24b35

@exlemor didn't get the issues you described.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43608.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43608.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 18, 2024
@Hackwar Hackwar enabled auto-merge (squash) August 29, 2024 09:17
@Hackwar Hackwar added this to the Joomla! 5.2.0 milestone Aug 29, 2024
@Hackwar
Copy link
Member

Hackwar commented Aug 29, 2024

Thank you for your contribution, @Fedik!

@Hackwar Hackwar merged commit 56a4640 into joomla:5.2-dev Aug 29, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 29, 2024
@Fedik Fedik deleted the plg-event-media-action branch August 29, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants