-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] Small fix for the dt- tag in content details list #43729
Conversation
Co-authored-by: Quy <[email protected]>
Why not fix it this way |
Can do. Do you think it is worth? It is not a big issue ... just somthing for accuracy fanatics like us |
Assuming of course that it is the correct thing to do and wcag seems to suggest that it is the correct way and even without hiding the "Details" it is wrong. https://www.w3.org/WAI/tutorials/page-structure/content/#description-lists |
I like this quote. So I make this a draft for now. |
its a very famous "english" quote. I am sure there will be a german equivalent |
Reviewing the code for this details block I think it is better to leave as is and just add this PR. |
I have tested this item ✅ successfully on e11afa7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43729. |
1 similar comment
I have tested this item ✅ successfully on e11afa7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43729. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43729. |
I've moved this to 5.2, I agree it's a bug fix, but what could happen is, that suddenly now with templates not supporting the CSS class, the label could appear, although it's disabled. |
Thanks @chmst ! |
Pull Request for Issue # .
Summary of Changes
The article info in articles is built as a definition list.
The definion term is the text for Details,
The definition description is a list of different items like author, publishing-date ad so on
If the user decides to hide the definition term then the dt-tag remains empty.
With this small PR the the details info is not empty but hides the text only for sighted users, screen readers still have the complete definition term.
This PR is of type "better than nothing"
because a more correct solution for the would be a definition list which writes for every element
<dt>Author</dt><dd>Mr. John Doe</dd>
Testing Instructions
Easiest test is any blog in joomla.
Just set some detail info in the corresponding menu item to "show"
Then show and hide the details
No change in frontend for sighted users, but check the source code.
Actual result BEFORE applying this Pull Request
If the Article Info Title is set on "hide". The dt is empty
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed