Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] [Guided tours] dark mode colors do not contrast well against the overall interface #43854

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

obuisard
Copy link
Contributor

@obuisard obuisard commented Jul 26, 2024

Summary of Changes

Guided tours popups do not have a good contrast against the Joomla backend.
It is very difficult to distinguish the tour popups from the rest and even know what the step targets are.
This PR proposes to improve the contrast and change the popup colors for dark mode.
We are keeping visual cues from the light version (darker header color than the popup content).
The header color is the same color as the editor header, so that we keep colors similar in the template.

Testing Instructions

Run any tour once in light and once in dark mode.
You can try and test in conjunction with PR#43825 (to fix the arrows).

Actual result BEFORE applying this Pull Request

image

image

Expected result AFTER applying this Pull Request

image

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Sorry, something went wrong.

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.2-dev labels Jul 26, 2024
@brianteeman
Copy link
Contributor

I didn't find any issue with the existing colours but if others do then this PR works as described


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43854.

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 1d3a1ee


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43854.

1 similar comment
@ChristineWk
Copy link

I have tested this item ✅ successfully on 1d3a1ee


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43854.

@ChristineWk
Copy link

OT: When checking in dark mode, I see this:

issue43854

@Hackwar Hackwar added the RTC This Pull Request is Ready To Commit label Jul 27, 2024
@pe7er pe7er enabled auto-merge (squash) August 8, 2024 18:25
@pe7er pe7er self-assigned this Aug 8, 2024
@pe7er pe7er merged commit 2850157 into joomla:5.2-dev Aug 8, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 8, 2024
@pe7er
Copy link
Contributor

pe7er commented Aug 8, 2024

Thanks @obuisard !

@obuisard
Copy link
Contributor Author

obuisard commented Aug 8, 2024

Thank you!

@Quy Quy added this to the Joomla! 5.2.0 milestone Aug 8, 2024
@obuisard obuisard deleted the guided-tours-darkmode branch October 29, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.2-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants