[5.2] [Guided tours] dark mode colors do not contrast well against the overall interface #43854
+9
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Guided tours popups do not have a good contrast against the Joomla backend.
It is very difficult to distinguish the tour popups from the rest and even know what the step targets are.
This PR proposes to improve the contrast and change the popup colors for dark mode.
We are keeping visual cues from the light version (darker header color than the popup content).
The header color is the same color as the editor header, so that we keep colors similar in the template.
Testing Instructions
Run any tour once in light and once in dark mode.
You can try and test in conjunction with PR#43825 (to fix the arrows).
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed