Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Add name to the select image event #43859

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Jul 29, 2024

Summary of Changes

Adds the name property to the select events.

Testing Instructions

Open the media manager.

Actual result BEFORE applying this Pull Request

All works.

Expected result AFTER applying this Pull Request

All works.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
laoneo Allon Moritz
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.2-dev labels Jul 29, 2024
@dgrammatiko
Copy link
Contributor

I have tested this item ✅ successfully on b1dbb61


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43859.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@hytsch
Copy link

hytsch commented Aug 7, 2024

I have tested this item ✅ successfully on 75f0d1d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43859.

@Quy
Copy link
Contributor

Quy commented Aug 7, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43859.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 7, 2024
@pe7er pe7er self-assigned this Aug 9, 2024
@pe7er pe7er enabled auto-merge (squash) August 9, 2024 08:58
@pe7er pe7er disabled auto-merge August 9, 2024 09:02

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@pe7er pe7er enabled auto-merge (squash) August 9, 2024 11:45
@pe7er pe7er merged commit 5372aae into joomla:5.2-dev Aug 9, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 9, 2024
@Quy Quy added this to the Joomla! 5.2.0 milestone Aug 9, 2024
@pe7er
Copy link
Contributor

pe7er commented Aug 9, 2024

Thanks @laoneo !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.2-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants