Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Fix saving edited images in media manager #44160

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Sep 29, 2024

Summary of Changes

When editing an image and trying to save it in 5.2-dev, the save button returns an error instead of saving the image. This PR fixes that.

Testing Instructions

Go to the media manager and edit an image. Rotate the image for example and open the developer tools. Click the Save button at the top.

Actual result BEFORE applying this Pull Request

See an error in the browser developer tools and the image isn't saved.

Expected result AFTER applying this Pull Request

The image is properly saved.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on d4b4769


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44160.

@richard67
Copy link
Member

It seems that change got lost when merging up PR #43906 , possibly due to some conflict resolution.

@exlemor
Copy link

exlemor commented Sep 29, 2024

I have tested this item ✅ successfully on d4b4769

I have tested this successfully. I have cropped, rotated, resized, re-cropped, re-rotated. All worked without issue.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44160.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44160.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 29, 2024
@Hackwar Hackwar merged commit 20cfbbf into joomla:5.2-dev Sep 29, 2024
3 of 4 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 29, 2024
@Hackwar Hackwar added this to the Joomla! 5.2.0 milestone Sep 29, 2024
@Hackwar Hackwar deleted the 5.2-media-save branch September 29, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants