-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] Articles Module: Display not only titles by default #44202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have tested this item ✅ successfully on c5b50da This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44202. |
@Hackwar Quy is right, it needs to change the default value from 1 to 0 in that line. |
I have tested this item ✅ successfully on c5b50da This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44202. |
richard67
added
the
Updates Requested
Indicates that this pull request needs an update from the author and should not be tested.
label
Oct 8, 2024
Hackwar
removed
the
Updates Requested
Indicates that this pull request needs an update from the author and should not be tested.
label
Oct 8, 2024
I changed the second parameter as well. |
I've restored the previous human test results in the issue tracker as the commit which has invalidated the test count has no functional impact on the tests. |
richard67
added
the
Updates Requested
Indicates that this pull request needs an update from the author and should not be tested.
label
Oct 8, 2024
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44202. |
richard67
removed
the
Updates Requested
Indicates that this pull request needs an update from the author and should not be tested.
label
Oct 8, 2024
Thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The Articles module right now is set to only display titles by default and then hides all other options. This is confusing and this PR switches that behavior around.
Testing Instructions
Create a new Articles module instance.
Actual result BEFORE applying this Pull Request
You only see the option "Show titles only" being set to "Yes". Rest is hidden.
Expected result AFTER applying this Pull Request
Option "Show titles only" is set to "No" by default and all other options are displayed.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed