Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Articles Module: Display not only titles by default #44202

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Oct 7, 2024

Summary of Changes

The Articles module right now is set to only display titles by default and then hides all other options. This is confusing and this PR switches that behavior around.

Testing Instructions

Create a new Articles module instance.

Actual result BEFORE applying this Pull Request

You only see the option "Show titles only" being set to "Yes". Rest is hidden.

Expected result AFTER applying this Pull Request

Option "Show titles only" is set to "No" by default and all other options are displayed.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@fgsw
Copy link

fgsw commented Oct 8, 2024

I have tested this item ✅ successfully on c5b50da


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44202.

@richard67
Copy link
Member

Update https://github.com/Hackwar/joomla-cms/blob/c5b50dacf4d0fa244ab14ed1d7bb8bb46d89a6cb/modules/mod_articles/tmpl/default.php#L36

@Hackwar Quy is right, it needs to change the default value from 1 to 0 in that line.

@dautrich
Copy link

dautrich commented Oct 8, 2024

I have tested this item ✅ successfully on c5b50da


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44202.

@richard67 richard67 added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Oct 8, 2024
@Hackwar Hackwar requested a review from chmst as a code owner October 8, 2024 12:57
@Hackwar Hackwar removed the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Oct 8, 2024
@Hackwar
Copy link
Member Author

Hackwar commented Oct 8, 2024

I changed the second parameter as well.

@richard67
Copy link
Member

I've restored the previous human test results in the issue tracker as the commit which has invalidated the test count has no functional impact on the tests.

@richard67 richard67 added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Oct 8, 2024
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44202.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 8, 2024
@richard67 richard67 removed the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Oct 8, 2024
@bembelimen bembelimen merged commit 74c81e6 into joomla:5.2-dev Oct 8, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 8, 2024
@bembelimen
Copy link
Contributor

Thx

@bembelimen bembelimen added this to the Joomla! 5.2.0 milestone Oct 8, 2024
@Hackwar Hackwar deleted the 5.2-module-title branch November 24, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants