-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.2 dev Fix breadcrumbs color in light and darkmode, fix for 44134 #44212
5.2 dev Fix breadcrumbs color in light and darkmode, fix for 44134 #44212
Conversation
I have tested this item ✅ successfully on b62a2c6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44212. |
Shouldn't the border be rather removed in dark? It's the last item |
I removed the border from the last item generally because the border is shaped like an arrow and implies that something on the right of it is not visible |
I have tested this item ✅ successfully on 2696d61 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44212. |
@brianteeman — why thumbs down? In normal breadcrumbs, you don't have an arrow icon after the last item either? |
because it was an intentional design decision to visually style the breadcrumbs in this way |
But its wrong ? |
@coolcat-creations I think it is better with border. Because without border it looks like text floating nowhere, and design of this element looks like incomplete. |
I have tested this item ✅ successfully on 5d8c411 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44212. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44212. |
Maintainers have decided to merge this for now , as the visibility of the text is important. The border should be re-added also for light mode. It would be great if you can re-add the border, @coolcat-creations. |
Thank you for this fix! |
Pull Request for Issue #44134 .
Summary of Changes
Assiged body color to the last item of breadcrumbs
Testing Instructions
Download the test package
Navigate to media manager
navigate into a deeper folder
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
[ x] No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
[ x] No documentation changes for manual.joomla.org needed