Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.2 dev Fix breadcrumbs color in light and darkmode, fix for 44134 #44212

Merged
merged 4 commits into from
Feb 3, 2025

Conversation

coolcat-creations
Copy link
Contributor

Pull Request for Issue #44134 .

Summary of Changes

Assiged body color to the last item of breadcrumbs

Testing Instructions

Download the test package
Navigate to media manager
navigate into a deeper folder

Actual result BEFORE applying this Pull Request

grafik

Expected result AFTER applying this Pull Request

grafik

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • [ x] No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • [ x] No documentation changes for manual.joomla.org needed

@Quy
Copy link
Contributor

Quy commented Oct 8, 2024

I have tested this item ✅ successfully on b62a2c6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44212.

@brianteeman
Copy link
Contributor

Almost but not quite. The text is now visible but the border is still invisible

image

image

@coolcat-creations
Copy link
Contributor Author

Shouldn't the border be rather removed in dark? It's the last item

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester and removed Unit/System Tests labels Oct 9, 2024
@coolcat-creations
Copy link
Contributor Author

I removed the border from the last item generally because the border is shaped like an arrow and implies that something on the right of it is not visible

@fgsw
Copy link

fgsw commented Oct 10, 2024

I have tested this item ✅ successfully on 2696d61


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44212.

@coolcat-creations
Copy link
Contributor Author

@brianteeman — why thumbs down? In normal breadcrumbs, you don't have an arrow icon after the last item either?

@brianteeman
Copy link
Contributor

@brianteeman — why thumbs down? In normal breadcrumbs, you don't have an arrow icon after the last item either?

because it was an intentional design decision to visually style the breadcrumbs in this way

@coolcat-creations
Copy link
Contributor Author

But its wrong ?

@Fedik
Copy link
Member

Fedik commented Nov 22, 2024

@coolcat-creations I think it is better with border. Because without border it looks like text floating nowhere, and design of this element looks like incomplete.
And when it not the last folder in the tree the "chevron" suggests that User can go deeper, kind of 😉

@Hackwar Hackwar added the bug label Nov 23, 2024
@chmst chmst added the RMDQ ReleaseManagerDecisionQueue label Jan 23, 2025
@chmst chmst removed the RMDQ ReleaseManagerDecisionQueue label Feb 3, 2025
@chmst
Copy link
Contributor

chmst commented Feb 3, 2025

I have tested this item ✅ successfully on 5d8c411


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44212.

@chmst chmst added the RMDQ ReleaseManagerDecisionQueue label Feb 3, 2025
@chmst
Copy link
Contributor

chmst commented Feb 3, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44212.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 3, 2025
@chmst
Copy link
Contributor

chmst commented Feb 3, 2025

Maintainers have decided to merge this for now , as the visibility of the text is important. The border should be re-added also for light mode. It would be great if you can re-add the border, @coolcat-creations.

@Hackwar Hackwar merged commit a89c179 into joomla:5.2-dev Feb 3, 2025
4 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 3, 2025
@Hackwar Hackwar added this to the Joomla! 5.2.4 milestone Feb 3, 2025
@Hackwar
Copy link
Member

Hackwar commented Feb 3, 2025

Thank you for this fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.2-dev RMDQ ReleaseManagerDecisionQueue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants