Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Archive Content - layouts #44601

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Conversation

brianteeman
Copy link
Contributor

Pull Request for Issue #38952 .

Summary of Changes

Archive Content view does not obey all the article options. Amongst other reasons this is because it was not using the layout

Testing Instructions

Create a new article in a new category
set the article to archive
Create a menu item for archived articles
Test the article options in the menu item to hide/show category, date, details etc

Before

All the options work except for hiding Article Info Title
image
image

After

All works as expected
image
image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Signed-off-by: BrianTeeman <[email protected]>
@fgsw
Copy link

fgsw commented Dec 12, 2024

@brianteeman Using prebuilt package and change setting Position of Article Info in Articles: Options give:

Above (correct)
archive-above
Below (no article info shown)
archive-below
Split (article info shown above and below text; hits not shown)
archive-split

@brianteeman
Copy link
Contributor Author

Thanks for testing - I will take another look

Signed-off-by: BrianTeeman <[email protected]>
@brianteeman
Copy link
Contributor Author

@fgsw fixed - it was a silly copy paste error

@fgsw
Copy link

fgsw commented Dec 12, 2024

I have tested this item ✅ successfully on 560c6bc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44601.

@alikon
Copy link
Contributor

alikon commented Jan 9, 2025

Test successfully by @Quy

@alikon
Copy link
Contributor

alikon commented Jan 9, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44601.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 9, 2025
@rdeutz rdeutz merged commit bb33b84 into joomla:5.3-dev Jan 10, 2025
4 checks passed
@rdeutz
Copy link
Contributor

rdeutz commented Jan 10, 2025

Thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 10, 2025
@brianteeman brianteeman deleted the archive_content branch January 10, 2025 10:09
@LadySolveig LadySolveig added this to the Joomla! 5.3.0 milestone Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants