-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.3] Archive Content - layouts #44601
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: BrianTeeman <[email protected]>
Signed-off-by: BrianTeeman <[email protected]>
@brianteeman Using prebuilt package and change setting Above (correct) |
Thanks for testing - I will take another look |
Signed-off-by: BrianTeeman <[email protected]>
@fgsw fixed - it was a silly copy paste error |
I have tested this item ✅ successfully on 560c6bc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44601. |
Test successfully by @Quy |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44601. |
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #38952 .
Summary of Changes
Archive Content view does not obey all the article options. Amongst other reasons this is because it was not using the layout
Testing Instructions
Create a new article in a new category
set the article to archive
Create a menu item for archived articles
Test the article options in the menu item to hide/show category, date, details etc
Before
All the options work except for hiding Article Info Title
After
All works as expected
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed