[Fix] Mail: allow domains as domain.edu.co

[infograf768]

Former patches did not let enter emails of type [email protected] (double dotted domains)

This will let them saved OK.

[wilsonge]

test: emails with 2 fullstops in domain work. A selection of other emails also seem to pass without any issues.

[MATsxm]

@test

able to reproduce then #4905 works as expected with double dotted domains AND without like contact@test

thanks

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4905.

[infograf768]

In fact this does not validate as @Domain is not accepted. See /tests/unit/suites/libraries/joomla/form/rule/JFormRuleEmailTest.php
( array('test3@localhost', false), )

[infograf768]

I corrected the helper but the validation is still wrong, I guess because of the code in:
/Applications/MAMP/htdocs/trunkgitnew/libraries/joomla/form/rule/email.php
We could return false there if the domain does not contain a dot.

        $atIndex = strrpos($value, '@');
        $domain = substr($value, $atIndex + 1);

        // Check if domain contains a dot
        $domainDot = strstr($domain, '.');

        if ($domainDot === false)
        {
            return false;
        }

What do you think?
I am a bit confused by the code in /tests/unit/suites/libraries/joomla/form/rule/JFormRuleEmailTest.php

we have there
array('firstname@localhost', true)
array('[email protected],[email protected],test3@localhost', true)
but
array('test3@localhost', false),

[infograf768]

The question, in fact, is:
"Shall we authorise or not domains without a suffix?"

[infograf768]

See: http://www.symantec.com/connect/blogs/important-changes-ssl-certificates-intranets-what-you-need-know

[MATsxm]

"Shall we authorise or not domains without a suffix?"

I am not an expert but I don't see why we should not?
I may be wrong but it seems to me that this is even useful in some cases (I can't find anymore why but I think it has to do with local servers)

[brianteeman]

It is very useful where Joomla is used on an intranet where they might use
internal addresses such as name@company
On 24 Oct 2014 11:17, "Marc-Antoine" [email protected] wrote:

"Shall we authorise or not domains without a suffix?"

I am not an expert but I don't see why we should not?
I may be wrong but it seems to me that this is even useful in some cases
(I can't find anymore why but I think it has to do with local servers)

—
Reply to this email directly or view it on GitHub
#4905 (comment).

[infograf768]

If all agree, I will then revert
infograf768@b7621c2

and we just have to correct the validation to be always true in
/tests/unit/suites/libraries/joomla/form/rule/JFormRuleEmailTest.php

[wilsonge]

I think there are valid reasons why these should not validate (e.g. http://www.symantec.com/connect/blogs/important-changes-ssl-certificates-intranets-what-you-need-know)

[phproberto]

👍 to support domains without dots. We should not restrict email addresses more than the standards

[infograf768]

Let's see if test pass this time. :)

[infograf768]

WE still have

1. JFormRuleEmailTest::testEmailData3 with data set Test #2 ('[email protected]', false)

[email protected] should have returned false but did not

Failed asserting that true matches expected false.

not passing.

[rdeutz]

looked into it and have send a PR to your branch JM

[infograf768]

@rdeutz
Have you got a reference concerning the validity of domain.c ?

[infograf768]

Merged Robert pull after discussion on skype

[Devportobello]

both regex a same now!

[brianteeman]

Almost but not quite - look at the final few characters

[Devportobello]

Sry, i wanted mean like line 26 https://github.com/infograf768/joomla-cms/blob/2d33d95df58f6da7a2d6ea32a345c02648c5fb2b/libraries/joomla/form/rule/email.php#L26