Avoid ignore SQL statement after comments starting by #

[jsanchezgr]

Description

When you try to install a component with some comments starting by # in SQL files, the following statement is ignored. This PR solves the issue #9008 by deleting all the comments starting by #

How to test

1. Install latest staging.
2. Get a component package ready to install.
3. Unzip the component and edit administrator/sql/install.mysql.utf8.sql file by adding some comments starting by #
4. Zip your component again and then install. The component is installed ok, but the following SQL statements to comments will be omited and may cause some errors in your component.
5. Uninstall the component.
6. Apply this patch.
7. Repeat steps 2 to 4.
8. Now the installer is working right.

[brianteeman]

I couldnt repeat the issue so have not been able to test the patch

I followed all the steps above and in step 3 I added the following at the very top of the sql

this is a comment

I then proceeded as above with step 4 but ALL the sql in the administrator/sql/install.mysql.utf8.sql were processed

Did I do something wrong?

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9137.}

[brianteeman]

oops markdown modified what I wrote
# this is a comment

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9137.}

[laoneo]

I have tested this item ✅ successfully on 1ef6317

I tested it successfully with DPCalendar.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9137.}

[jsanchezgr]

Brian, have you tried to install a fresh component or have you tried to update it? To replicate the issue you must install a component that is not already installed.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9137.}

[laoneo]

I can provide a modified DPCalendar version if needed to test.

[brianteeman]

it was a clean web site installed just for this test using the current
staging

On 17 February 2016 at 12:36, Allon Moritz [email protected] wrote:

I can provide a modified DPCalendar version if needed to test.

—
Reply to this email directly or view it on GitHub
#9137 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

[brianteeman]

Tested again using DPCalendar where I added
# this is a comment
to the very first line of /com_dpcalendar/admin/sql/install.mysql.utf8.sql

Again had no problem at all

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9137.}

[brianteeman]

I have tested this item 🔴 unsuccessfully on 1ef6317

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9137.}

[jsanchezgr]

Brian, if you test the issue with DPCalendar by adding a comment to the very first line of com_dpcalendar/admin/sql/install.mysql.utf8.sql the installer works ok, but the component not. Just after installing, go to Components->DP Calendar->Events and you'll get the following SQL error:

#__dpcalendar_events' doesn't exist SQL=SELECT u.id AS value, u.name AS text FROM #__users AS u INNER JOIN #__dpcalendar_events AS c ON c.created_by = u.id GROUP BY u.id, u.name ORDER BY u.name

This is because the events table is missing in your database.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9137.}

[brianteeman]

Ah I tested the other views in dpcalendar and they were ok. They were all
OK in my own component.
On 17 Feb 2016 1:40 pm, "Juan" [email protected] wrote:

Brian, if you test the issue with DPCalendar by adding a comment to the
very first line of com_dpcalendar/admin/sql/install.mysql.utf8.sql the
installer works ok, but the component not. Just after installing, go to
Components->DP Calendar->Events and you'll get the following SQL error:

#__dpcalendar_events' doesn't exist SQL=SELECT u.id AS value, u.name AS
text FROM #__users AS u INNER JOIN #__dpcalendar_events AS c ON
c.created_by = u.id GROUP BY u.id, u.name ORDER BY u.name

This is because the events table is missing in your database.

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/9137
https://issues.joomla.org/tracker/joomla-cms/9137.

—
Reply to this email directly or view it on GitHub
#9137 (comment).

[brianteeman]

I have tested this item ✅ successfully on 1ef6317

Got it now - sorry for confusion
I thought you meant that evetything after the comment would be ignored when you meant the first thing after the comment

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9137.}

[brianteeman]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9137.}

[wilsonge]

Merged