Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1] Action Logs improved search #2176

Closed
jgerman-bot opened this issue Dec 13, 2021 · 0 comments · Fixed by #2190
Closed

[4.1] Action Logs improved search #2176

jgerman-bot opened this issue Dec 13, 2021 · 0 comments · Fixed by #2190

Comments

@jgerman-bot
Copy link

New language relevant PR in upstream repo: joomla/joomla-cms#36242 Here are the upstream changes:

Click to expand the diff!
diff --git a/administrator/components/com_actionlogs/src/Model/ActionlogsModel.php b/administrator/components/com_actionlogs/src/Model/ActionlogsModel.php
index 9b5edc674437..854164246d54 100644
--- a/administrator/components/com_actionlogs/src/Model/ActionlogsModel.php
+++ b/administrator/components/com_actionlogs/src/Model/ActionlogsModel.php
@@ -166,8 +166,8 @@ protected function getListQuery()
 			else
 			{
 				$search = '%' . $search . '%';
-				$query->where($db->quoteName('u.username') . ' LIKE :username')
-					->bind(':username', $search);
+				$query->where($db->quoteName('a.message') . ' LIKE :message')
+					->bind(':message', $search);
 			}
 		}
 
diff --git a/administrator/language/en-GB/com_actionlogs.ini b/administrator/language/en-GB/com_actionlogs.ini
index fb73eab67b59..483b44575332 100644
--- a/administrator/language/en-GB/com_actionlogs.ini
+++ b/administrator/language/en-GB/com_actionlogs.ini
@@ -31,7 +31,7 @@ COM_ACTIONLOGS_FIELD_VALUE_GET="GET"
 COM_ACTIONLOGS_FIELD_VALUE_PATCH="PATCH"
 COM_ACTIONLOGS_FIELD_VALUE_POST="POST"
 COM_ACTIONLOGS_FIELD_VALUE_PUT="PUT"
-COM_ACTIONLOGS_FILTER_SEARCH_DESC="Search in username. Prefix with ID: to search for an action log ID."
+COM_ACTIONLOGS_FILTER_SEARCH_DESC="Search in action. Prefix with ID: to search for an action log ID."
 COM_ACTIONLOGS_FILTER_SEARCH_LABEL="Search Actions Log"
 COM_ACTIONLOGS_IP_ADDRESS="IP Address"
 COM_ACTIONLOGS_IP_ADDRESS_ASC="IP Address ascending"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants