Standards fixes

joomlashack · Jun 29, 2023 · 28ac5b8 · 28ac5b8
1 parent 8927d82
commit 28ac5b8
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/src/admin/models/file.php b/src/admin/models/file.php
@@ -31,7 +31,10 @@
 use Joomla\CMS\Table\Table;
 use Joomla\Registry\Registry;
 
+// phpcs:disable PSR1.Files.SideEffects
 defined('_JEXEC') or die();
+// phpcs:enable PSR1.Files.SideEffects
+// phpcs:disable PSR1.Classes.ClassDeclaration.MissingNamespace
 
 class OsdownloadsModelFile extends AdminModel
 {
@@ -236,7 +239,7 @@ protected function gcFileUploads()
      * @return void
      * @throws Exception
      */
-    protected function uploadFile(&$data)
+    protected function uploadFile(array &$data): void
     {
         $app    = Factory::getApplication();
         $files  = $app->input->files->get('jform', [], 'raw');
@@ -245,10 +248,11 @@ protected function uploadFile(&$data)
         $fileName = $upload->get('name');
         if (empty($fileName)) {
             if (empty($data['file_path'])) {
-                if (isset($files['file_path_upload']['name'])) {
-                    $error = 'COM_OSDOWNLOADS_UPLOAD_ERR_REQUIRED';
-                } else {
+                if (empty($files['file_path_upload']['name'])) {
                     $error = 'COM_OSDOWNLOADS_UPLOAD_ERR_EMPTY_FIELD';
+
+                } else {
+                    $error = 'COM_OSDOWNLOADS_UPLOAD_ERR_REQUIRED';
                 }
 
                 throw new Exception(Text::_($error));

diff --git a/src/admin/models/files.php b/src/admin/models/files.php
@@ -25,7 +25,10 @@
 use Joomla\CMS\MVC\Model\ListModel;
 use Joomla\CMS\Table\Table;
 
+// phpcs:disable PSR1.Files.SideEffects
 defined('_JEXEC') or die();
+// phpcs:enable PSR1.Files.SideEffects
+// phpcs:disable PSR1.Classes.ClassDeclaration.MissingNamespace
 
 class OsdownloadsModelFiles extends ListModel
 {