Fix currency issues in latest release #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new currency data structure does not use a `.value` property anymore.
Closed
Currency has weight, 50 coins == 1 lb. This change adds an option to the settings to include that currency weight to the Total Weight calculation.
|
I've included my optional currency weight PR with this one as well. |
|
This fixes the issue against the current master 3.2.1? |
|
It should be. I just reforked the repo before making the changes. |
|
Awesome, thanks. Got into this mess because I can’t currently test things :/ I’ll review and merge this tomorrow.
… On Oct 18, 2021, at 7:14 PM, flamewave000 ***@***.***> wrote:
It should be. I just reforked the repo before making the changes.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to two separate conflicting PRs that came into the loot sheet repo, currency was terribly broken. This PR corrects the issues and gets currency working again.
This will likely fix issues #184, #185, and #187