Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public interface with factory methods, hide implementation #38

Closed
wants to merge 6 commits into from

Conversation

HomeOfTheWizard
Copy link

@HomeOfTheWizard HomeOfTheWizard commented May 12, 2023

  • Create a public interface with static factory methods
  • make implementation class private
  • replace usage of impl class constructor with interface factory methods

henryx added a commit that referenced this pull request May 14, 2023
henryx added a commit that referenced this pull request May 14, 2023
@henryx
Copy link
Collaborator

henryx commented May 14, 2023

Thank you for the PR. Because I cannot founded a simple method to solve conflicts, I've merged this PR manually (see referenced commits)

@henryx henryx closed this May 14, 2023
@HomeOfTheWizard
Copy link
Author

Thank you. My bad, I think I forgot to tick the box to allow you editing the PR so you could resolve the conflicts.
For future PRs, I would like to help you maintain the library if you are willing to give write access to the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants