Add vim-tmux-navigator #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 27, 2023 15:38
jordanisaacs
requested changes
Mar 30, 2023
There was a problem hiding this comment.
lgtm, I just left some style changes. Unless the name would look wrong (eg. nullLs) I prefer snake case standardized. Also if you could add to the changelog.
| @@ -1,2 +1,3 @@ | |||
| result | |||
| .config | |||
| .direnv | |||
| ${optionalString (cfg.autosave-on-leave == "update") "let g:tmux_navigator_save_on_switch = 1"} | ||
| ${optionalString (cfg.autosave-on-leave == "wall") "let g:tmux_navigator_save_on_switch = 2"} | ||
| ${optionalString (cfg.disable-when-zoomed) "let g:tmux_navigator_disable_when_zoomed = 1"} | ||
| ${optionalString (cfg.preserve-zoom) "let g:tmux_navigator_preserve_zoom = 1"} |
There was a problem hiding this comment.
Suggested change
| ${optionalString (cfg.preserve-zoom) "let g:tmux_navigator_preserve_zoom = 1"} | |
| ${optionalString (cfg.preserve-zoom) "let g:tmux_navigator_preserve_zoom = 1"} |
Comment on lines
+40
to
+42
| vim.startPlugins = [ | ||
| "tmux-navigator" | ||
| ]; |
There was a problem hiding this comment.
Suggested change
| vim.startPlugins = [ | |
| "tmux-navigator" | |
| ]; | |
| vim.startPlugins = ["tmux-navigator"]; |
| description = "enable tmux-navigator, this plugin will only work together with tmuxPlugins.vim-tmux-navigator"; | ||
| }; | ||
|
|
||
| autosave-on-leave = mkOption { |
There was a problem hiding this comment.
Suggested change
| autosave-on-leave = mkOption { | |
| autosaveOnLeave = mkOption { |
| description = "enable autosave when navigating to tmux"; | ||
| }; | ||
|
|
||
| disable-when-zoomed = mkOption { |
There was a problem hiding this comment.
Suggested change
| disable-when-zoomed = mkOption { | |
| disableWhenZoomed = mkOption { |
| description = "disable navigator when the tmux pane is zoomed"; | ||
| }; | ||
|
|
||
| preserve-zoom = mkOption { |
There was a problem hiding this comment.
Suggested change
| preserve-zoom = mkOption { | |
| preserveZoom = mkOption { |
| cfg = config.vim.tmux-navigator; | ||
| in { | ||
| options.vim = { | ||
| tmux-navigator = { |
There was a problem hiding this comment.
Suggested change
| tmux-navigator = { | |
| tmuxNavigator = { |
| in { | ||
| options.vim = { | ||
| tmux-navigator = { | ||
| enable = mkOption { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first pr for this project so i'm not sure if i haven't missed something.