Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge development into main #111

Merged
merged 28 commits into from
Jan 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
b6428ab
perf(home): compress home banner image
thread-koder Jan 18, 2024
f584cf3
refactor(charts): remove x-axis padding and margin
thread-koder Jan 18, 2024
503d2f1
refactor(components): remove x-axis margin and padding from the card
thread-koder Jan 18, 2024
de07e60
refactor(components): add a name prop to the charts period drop down
thread-koder Jan 18, 2024
0f84c90
refactor(components): remove x-axis padding and margins from contribu…
thread-koder Jan 18, 2024
a79d523
refactor(components): change the filter section styles
thread-koder Jan 18, 2024
4b567a3
refactor(components): change the hero css styles
thread-koder Jan 18, 2024
b00835f
refactor(components): change the css for the home page banner
thread-koder Jan 18, 2024
223ba0f
refactor(components): change css for the inputs section
thread-koder Jan 18, 2024
96438bc
refactor(components): change css style for the last updated
thread-koder Jan 18, 2024
4c8bc1f
perf(components): give images for the org user explicit width and height
thread-koder Jan 18, 2024
438d397
refactor(components): change css style for the organizations list
thread-koder Jan 18, 2024
e01401a
refactor(components): change css style for the organizations filter s…
thread-koder Jan 18, 2024
7d68008
refactor(components): change css style for the organizations inputs
thread-koder Jan 18, 2024
b0ec6aa
fix(semantics): remove the spans from under the ul html tag in the pa…
thread-koder Jan 18, 2024
fd76170
refactor(components): add a name prop to the period dropdown
thread-koder Jan 18, 2024
73d0145
refactor(components): change css style for the q and a component
thread-koder Jan 18, 2024
5a02caf
fix(components): remove the auto margin on the x-axis for the search …
thread-koder Jan 18, 2024
0a90df5
refactor(components): change css style for the stats
thread-koder Jan 18, 2024
c739f92
perf(footer): give images an explicit width and height
thread-koder Jan 18, 2024
afed5fb
refactor(components): change css style for the top contributors
thread-koder Jan 18, 2024
fa3aa91
refactor(components): change the css style for the top organizations
thread-koder Jan 18, 2024
a766301
fix(semantics): modify the html structure for the user card component
thread-koder Jan 18, 2024
85e93e7
refactor(pages): add a global padding on the home page
thread-koder Jan 18, 2024
03fb032
fix(pages): change css style for the contributors page
thread-koder Jan 18, 2024
bc21d09
refactor(pages): change css style for the methodology page
thread-koder Jan 18, 2024
81940f5
refactor(pages): change css style for the orgs page
thread-koder Jan 18, 2024
5053ebf
Merge pull request #110 from jordanopensource/fix/design-semantics-is…
thread-koder Jan 18, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 1 addition & 44 deletions assets/images/hero/jordan-commits.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion components/AreaChart.vue
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export default {

<style lang="postcss">
.chart-section-container {
@apply m-auto w-11/12 bg-white py-0 px-0 md:px-7 md:py-10;
@apply bg-white py-0 md:py-10;
}

.tooltip {
Expand Down
2 changes: 1 addition & 1 deletion components/BarChart.vue
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export default {

<style lang="postcss">
.bar-chart-section-container {
@apply m-auto w-11/12 bg-white py-0 px-0 md:px-7 md:py-10;
@apply bg-white py-0 md:py-10;
}

.bar-tooltip {
Expand Down
4 changes: 2 additions & 2 deletions components/Card.vue
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

<script>
export default {
name: 'Card',
name: 'StatCard',
props: {
count: { type: Number, required: true },
description: { type: String, required: true },
Expand Down Expand Up @@ -55,7 +55,7 @@ export default {
}

.card-container {
@apply bg-white shadow my-5 mx-3 lg:w-2/4 lg:mx-5;
@apply bg-white shadow my-5 lg:w-2/4;
}

.content-container {
Expand Down
11 changes: 7 additions & 4 deletions components/ChartsPeriodDropdown.vue
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<template>
<div>
<select id="period" name="period" @change="onChange">
<select :id="name" :name="name" @change="onChange">
<option value="last_year">Last Year</option>
<option value="this_year">This Year</option>
<option value="last_month">Last Month</option>
Expand All @@ -20,6 +20,9 @@
<script>
export default {
name: 'PeriodDropdown',
props: {
name: { type: String, default: 'period' },
},
data() {
return {
todayDate: new Date().toLocaleString('en-GB', {
Expand All @@ -31,21 +34,21 @@ export default {
{
day: 'numeric',
month: 'long',
}
},
),
firstDayOfTheLastMonth: 0,
lastDayOfTheLastMonth: new Date(
new Date().getFullYear(),
new Date().getMonth(),
0
0,
).toLocaleString('en-GB', {
day: 'numeric',
month: 'long',
}),
endOfTheYear: new Date(
new Date().getFullYear() - 1,
11,
31
31,
).toLocaleString('en-GB', {
day: 'numeric',
month: 'long',
Expand Down
10 changes: 5 additions & 5 deletions components/Contributors.vue
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
<div class="section-container">
<div class="content-conatiner">
<div class="text-section has-border">
<h1 class="hidden head-text md:block">Rank</h1>
<h1 class="head-text px-0 lg:px-7">User</h1>
<h3 class="hidden head-text md:block">Rank</h3>
<h3 class="head-text">User</h3>
<div class="flex justify-end w-full">
<h1 class="head-text">Total</h1>
<h3 class="head-text">Total</h3>
</div>
</div>
<div>
Expand Down Expand Up @@ -81,11 +81,11 @@ export default {
}

.section-container {
@apply block w-11/12 mx-auto lg:mx-0 bg-gray;
@apply block bg-gray;
}

.content-conatiner {
@apply mx-3 lg:mx-0 bg-white;
@apply bg-white;
}

.has-border {
Expand Down
7 changes: 3 additions & 4 deletions components/FilterSection.vue
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
isOpen ? 'filter-section has-border' : 'filter-section lg:has-border'
"
>
<h1 class="filter-text">Filter</h1>
<h3 class="filter-text">Filter</h3>
<button
:class="isOpen ? 'expand-button' : 'expand-button-collapsed'"
aria-label="Expand Filter Section"
Expand Down Expand Up @@ -50,12 +50,11 @@ export default {

<style lang="postcss" scoped>
.section-container {
@apply block w-11/12 lg:w-1/3 mx-auto lg:mx-0 lg:mr-5 lg:bg-lightgrey;
@apply block lg:w-[28%] lg:bg-lightgrey;
}

.content-conatiner {
background-color: #f4f4f5;
@apply mx-3 lg:mx-0;
}

.filter-section {
Expand All @@ -73,7 +72,7 @@ export default {
}

.sort-section {
@apply mx-6 pt-6 pb-4;
@apply pt-6 pb-4;
}

.contributions-radio {
Expand Down
6 changes: 3 additions & 3 deletions components/Hero.vue
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

<script>
export default {
name: 'Hero',
name: 'HeroBanner',
props: {
title: {
type: String,
Expand All @@ -33,7 +33,7 @@ export default {
}

.banner {
@apply flex flex-col mx-9 md:h-96 md:flex-row;
@apply flex flex-col px-8 md:px-14 lg:px-24 md:h-96 md:flex-row;
}

.content-container {
Expand All @@ -42,6 +42,6 @@ export default {

.content-header {
font-family: 'IBM Mono';
@apply text-4xl md:text-4xl lg:text-5xl tracking-wide font-normal md:mx-3 lg:mx-16;
@apply text-4xl md:text-4xl lg:text-5xl tracking-wide font-normal;
}
</style>
10 changes: 5 additions & 5 deletions components/HomePageHero.vue
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@

<script>
export default {
name: 'Hero',
name: 'HomeHeroBanner',
}
</script>

Expand All @@ -43,7 +43,7 @@ export default {
}

.banner {
@apply flex flex-col mx-9 h-auto md:flex-row;
@apply flex flex-col px-8 md:px-14 lg:px-24 h-auto md:flex-row;
}

.content-container {
Expand All @@ -52,15 +52,15 @@ export default {

.content-header {
font-family: 'IBM Mono';
@apply text-4xl md:text-4xl lg:text-5xl tracking-wide font-normal md:mx-3 lg:mx-16;
@apply text-4xl md:text-4xl lg:text-5xl tracking-wide font-normal;
}

.para-section {
font-family: 'IBM Sans';
@apply w-11/12 pt-7 text-xl lg:text-2xl font-normal md:mx-3 lg:mx-16 lg:w-9/12;
@apply w-11/12 pt-7 text-xl lg:text-2xl font-normal lg:w-9/12;
}

.section-image {
@apply my-8 place-self-end w-8/12 md:w-5/12 lg:w-80 lg:mt-14 2xl:w-96 lg:mr-12;
@apply my-8 place-self-end w-8/12 md:w-5/12 lg:w-80 2xl:w-96;
}
</style>
18 changes: 9 additions & 9 deletions components/InputsSection.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@
<SearchInput placeholder="Search Users..." @on-search="onSearch" />
</div>
<div class="sort-section">
<h6 class="text-xs font-bold pb-2">Period:</h6>
<div class="flex lg:flex-col gap-1">
<PeriodDropdown />
<label for="period" class="text-xs font-bold">Period:</label>
<div class="flex lg:flex-col gap-1 pt-1">
<PeriodDropdown name="period" />
</div>
</div>
<div class="sort-section has-border">
<h6 class="text-xs font-bold pb-2">Sort by:</h6>
<div class="flex lg:flex-col gap-1">
<span class="text-xs font-bold">Sort by:</span>
<div class="flex lg:flex-col gap-1 pt-1">
<RadioButton
class="lg:pb-1"
:input-id="`score`"
Expand All @@ -34,8 +34,8 @@
</div>
</div>
<div class="sort-section has-border">
<h6 class="text-xs font-bold pb-2">Show:</h6>
<div class="flex lg:flex-col gap-1">
<span class="text-xs font-bold">Show:</span>
<div class="flex lg:flex-col gap-1 pt-1">
<RadioButton
class="lg:pb-1"
:input-id="`all`"
Expand All @@ -58,8 +58,8 @@
</div>
</div>
<div class="sort-section">
<h6 class="text-xs font-bold pb-2">Count:</h6>
<div class="flex lg:flex-col justify-between gap-1">
<span class="text-xs font-bold">Count:</span>
<div class="flex lg:flex-col gap-3 pt-1">
<div class="flex">
<RadioButton
class="lg:pb-1"
Expand Down
2 changes: 1 addition & 1 deletion components/LastUpdated.vue
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<div v-if="lastUpdated" class="flex justify-end pt-5 ml-8 mr-8 md:mr-12 lg:mr-20 2xl:mr-28 ">
<div v-if="lastUpdated" class="flex justify-end pt-5">
<p class="opacity-50">
{{ lastUpdated }}
</p>
Expand Down
26 changes: 21 additions & 5 deletions components/OrganizationCard.vue
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,27 @@
<div class="flex mx-8 h-36 lg:h-48 content-center has-border pb-3">
<p class="rank hidden md:block">{{ rank }}.</p>
<div class="image-container">
<img class="image" :src="imageUrl" alt="avatar" width="80" height="80" />
<span class="image-filter"></span>
<a :href="profileUrl" target="_blank">
<img
class="image"
:src="imageUrl"
alt="avatar"
width="80"
height="80" />
<span class="image-filter"></span
></a>
</div>

<div class="block w-full pl-2 lg:px-3 mt-8 lg:mt-12">
<div class="flex flex-col">
<h3 class="full-name">{{ name }}</h3>
<div>
<span class="full-name">{{ name }}</span>
<div class="w-max">
<a :href="profileUrl" target="_blank" class="username-container">
<img
class="h-5 pr-1"
src="~assets/images/footer/icon-github.svg"
alt="Github Account"
width="auto"
width="25"
height="20"
loading="lazy"
/>
Expand Down Expand Up @@ -116,4 +123,13 @@ export default {
.image-container {
@apply self-center w-16 h-16 relative lg:w-20 lg:h-20;
}

a {
transition: all 0.3s ease 0s;
}

a:hover {
text-decoration: none;
color: #00b199;
}
</style>
10 changes: 5 additions & 5 deletions components/Organizations.vue
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
<div class="section-container">
<div class="content-conatiner">
<div class="text-section has-border">
<h1 class="hidden head-text md:block">Rank</h1>
<h1 class="head-text px-0 lg:px-7">Organization</h1>
<h3 class="hidden head-text md:block">Rank</h3>
<h3 class="head-text px-0 lg:px-7">Organization</h3>
<div class="flex justify-end w-full">
<h1 class="head-text">Total</h1>
<h3 class="head-text">Total</h3>
</div>
</div>
<div>
Expand Down Expand Up @@ -76,11 +76,11 @@ export default {
}

.section-container {
@apply block w-11/12 mx-auto lg:mx-0 bg-gray;
@apply block bg-gray;
}

.content-conatiner {
@apply mx-3 lg:mx-0 bg-white;
@apply bg-white;
}

.has-border {
Expand Down
7 changes: 3 additions & 4 deletions components/OrganizationsFilter.vue
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
isOpen ? 'filter-section has-border' : 'filter-section lg:has-border'
"
>
<h1 class="filter-text">Filter</h1>
<h3 class="filter-text">Filter</h3>
<button
:class="isOpen ? 'expand-button' : 'expand-button-collapsed'"
aria-label="Expand Filter Section"
Expand Down Expand Up @@ -50,12 +50,11 @@ export default {

<style lang="postcss" scoped>
.section-container {
@apply block w-11/12 lg:w-1/3 mx-auto lg:mx-0 lg:mr-5 lg:bg-lightgrey;
@apply block lg:w-[28%] lg:bg-lightgrey;
}

.content-conatiner {
background-color: #f4f4f5;
@apply mx-3 lg:mx-0;
}

.filter-section {
Expand All @@ -73,7 +72,7 @@ export default {
}

.sort-section {
@apply mx-6 pt-6 pb-4;
@apply pt-6 pb-4;
}

.contributions-radio {
Expand Down
4 changes: 2 additions & 2 deletions components/OrganizationsInput.vue
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
@on-search="onSearch"
/>
</div>
<h6 class="text-xs font-bold pb-2">Sort by:</h6>
<div class="flex lg:flex-col">
<span class="text-xs font-bold">Sort by:</span>
<div class="flex lg:flex-col pt-1">
<RadioButton
class="mr-3 lg:pb-2 lg:mr-0"
:input-id="`Total Stars`"
Expand Down
Loading