Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use current fish path instead of fish command #716

Merged
merged 1 commit into from
May 26, 2022
Merged

Use current fish path instead of fish command #716

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions functions/fisher.fish
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,13 @@ function fisher --argument-names cmd --description "A plugin manager for Fish"
set --local fetch_plugins $update_plugins $install_plugins
echo (set_color --bold)fisher $cmd version $fisher_version(set_color normal)

for plugin in $fetch_plugins
fish_path=(status fish-path) for plugin in $fetch_plugins
set --local source (command mktemp -d)
set --append source_plugins $source

command mkdir -p $source/{completions,conf.d,functions}

fish --command "
$fish_path --command "
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this also Fish 3.0 or was it introduced more recently?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this has been around for a while now. Just checking.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@faho Sorry to bother but would you happen to know when variable-in-command-position was released? Tried combing through the release notes but couldn't find it.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this is in since 3.0 as well! 🎉

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fish-shell/fish-shell@865a464

if test -e $plugin
command cp -Rf $plugin/* $source
else
Expand Down