Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline styles #675

Closed
wants to merge 1 commit into from
Closed

Inline styles #675

wants to merge 1 commit into from

Conversation

frenzzy
Copy link
Contributor

@frenzzy frenzzy commented Apr 2, 2018

It allows us to use bunch of valid html/svg code inside vdom tree without the need to convert a lot of inline styles into objects.

Fixes #672 (comment)

Demo: https://codepen.io/frenzzy/pen/OvEyeL/left/?editors=0010

@jorgebucaran
Copy link
Owner

I'd like to compare this with using cssText when style is a string.

@jorgebucaran jorgebucaran added the enhancement New feature or request label Apr 2, 2018
@codecov
Copy link

codecov bot commented Apr 2, 2018

Codecov Report

Merging #675 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #675   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines         161    161           
  Branches       50     50           
=====================================
  Hits          161    161
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90e1861...f2eb4c2. Read the comment docs.

@jorgebucaran
Copy link
Owner

@frenzzy Close here?

@frenzzy
Copy link
Contributor Author

frenzzy commented Apr 6, 2018

@jorgebucaran why do you think cssText version is better? This version looks shorter.
Possible issue could be a browser support here, but I haven't checked it yet.

@jorgebucaran
Copy link
Owner

Thanks, @frenzzy. I am going to abandon this feature for the same reason given here as I hold the same opinion.

@frenzzy frenzzy deleted the inline-styles branch September 7, 2018 14:08
@jorgebucaran jorgebucaran added the outdated Forgotten lore label Sep 8, 2018
Repository owner locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request outdated Forgotten lore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants