Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usage of fish_user_paths with symlinks #94

Closed
wants to merge 3 commits into from
Closed

Replace usage of fish_user_paths with symlinks #94

wants to merge 3 commits into from

Conversation

thernstig
Copy link

fish_user_paths has the unfortunate side effect that if it points
to a path somewhere in the user's home directory, the path will be
set to the full path (i.e. /home/username/ instead of ~/) inside
the fish_variables file.

This is unfortunate because a user that wish to share the
fish_variables file between multiple computers, to get a unified
shell setup, it's not possible since the path will point to a home
directory that might not be the same between the host (since the
user possibly has different usernames on different hosts).

This aims to rememdy this by using symlinks instead of
the fish_user_paths variable.

/fixes #93

fish_user_paths has the unfortunate side effect that if it points
to a path somewhere in the user's home directory, the path will be
set to the full path (i.e. /home/username/ instead of ~/) inside
the fish_variables file.

This is unfortunate because a user that wish to share the
fish_variables file between multiple computers, to get a unified
shell setup, it's not possible since the path will point to a home
directory that might not be the same between the host (since the
user possibly has different usernames on different hosts).

This aims to rememdy this by using symlinks instead of
the fish_user_paths variable.
@thernstig
Copy link
Author

thernstig commented Oct 31, 2019

@jorgebucaran Let's see if you like this or not. The only downside I see is that I had to point out all of node, npm and npx. Your previous version was agnostic to this.

Comment on lines +4 to +6
if not contains $nvm_bin_path $PATH
set PATH $nvm_bin_path $PATH
end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems if we'd move this into nvm function itself (with appropriate configuration checking), it should also fix #101

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could look into that, but @jorgebucaran has not made any comments so I am not sure if he has any intention to merge this.

@jorgebucaran
Copy link
Owner

The only downside I see is that I had to point out all of node, npm and npx. Your previous version was agnostic to this.

This seems like a significant downside. 🤔

fish_user_paths has the unfortunate side effect that if it points
to a path somewhere in the user's home directory, the path will be
set to the full path (i.e. /home/username/ instead of ~/) inside
the fish_variables file.

Maybe fish_user_paths can address this issue in a future fish distribution if we propose a change! :)

I could look into that, but @jorgebucaran has not made any comments so I am not sure if he has any intention to merge this.

Thank you, but probably not at the moment. 🙇

@thernstig
Copy link
Author

thernstig commented Jan 29, 2020

@jorgebucaran It is possible to symlink a directory, getting rid of having to point out each individual binary. (Not that I think it is a big deal, it's not like it changes very often if at all).

I doubt they will change fish_user_paths.

What is the major reason you do not like the change. Is it that you do not like symlinks? The wording "probably not at the moment" leaves me in confusion why you wanted me to write this MR (which you asked for) and where you want it to go.

Repository owner locked and limited conversation to collaborators Jul 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not change fish_user_paths
3 participants