Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potential step and unwrapSteps to be generic #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −7
Open

potential step and unwrapSteps to be generic #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export const serializers = {
YamlSerializer,
};

export type PotentialStep = Step | Conditional<Step>;
export type PotentialStep<S extends Step = Step> = S | Conditional<S>;

export class Pipeline implements Serializable {
public readonly name: string;
Expand Down
12 changes: 6 additions & 6 deletions src/unwrapSteps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
import { PotentialStep, Step } from './index';
import { Conditional } from './conditional';

export type StepCache = Map<Conditional<Step>, Step>;
export type StepCache<S extends Step = Step> = Map<Conditional<S>, S>;

export async function unwrapSteps(
steps: PotentialStep[],
cache: StepCache,
export async function unwrapSteps<S extends Step = Step>(
steps: PotentialStep<S>[],
cache: StepCache<S>,
acceptAllConditions: boolean,
): Promise<Step[]> {
const ret: Step[] = [];
): Promise<S[]> {
const ret: S[] = [];
for (const s of steps) {
if (s instanceof Conditional) {
if (cache.has(s)) {
Expand Down