Skip to content

Commit

Permalink
fix: #138 text of tooltip in text mode not readable when using a dark…
Browse files Browse the repository at this point in the history
… theme
  • Loading branch information
josdejong committed Sep 9, 2022
1 parent 60a65d9 commit 5e7790e
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 1 deletion.
10 changes: 9 additions & 1 deletion src/lib/components/modes/textmode/TextMode.scss
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,17 @@
padding: 0 $padding;
}

:global(.cm-diagnostic) {
:global(.cm-tooltip) {
font-size: var(--jse-font-size);
font-family: var(--jse-font-family);
color: var(--jse-tooltip-color);
background: var(--jse-tooltip-background);
border: var(--jse-tooltip-border);
}

:global(.cm-diagnosticAction) {
background: var(--jse-tooltip-action-button-color);
background: var(--jse-tooltip-action-button-background);
}

:global(.cm-panels) {
Expand Down
7 changes: 7 additions & 0 deletions src/lib/themes/jse-theme-dark.css
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,13 @@
--jse-modal-overlay-background: rgba(0, 0, 0, 0.5);
--jse-modal-code-background: #2f2f2f;

/* tooltip in text mode */
--jse-tooltip-color: var(--jse-text-color);
--jse-tooltip-background: #4b4b4b;
--jse-tooltip-border: 1px solid #737373;
--jse-tooltip-action-button-color: inherit;
--jse-tooltip-action-button-background: #737373;

/* panels: navigation bar, gutter, search box */
--jse-panel-background: #333333;
--jse-panel-background-border: 1px solid #464646;
Expand Down
7 changes: 7 additions & 0 deletions src/lib/themes/jse-theme-default.css
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,13 @@
--jse-modal-overlay-background: rgba(0, 0, 0, 0.3);
--jse-modal-code-background: rgba(0, 0, 0, 0.05);

/* tooltip in text mode */
--jse-tooltip-color: var(--jse-text-color);
--jse-tooltip-background: var(--jse-modal-background);
--jse-tooltip-border: var(--jse-main-border);
--jse-tooltip-action-button-color: var(--jse-text-color-inverse);
--jse-tooltip-action-button-background: #4d4d4d;

/* panels: navigation bar, gutter, search box */
--jse-panel-background: #ebebeb;
--jse-panel-color: var(--jse-text-color);
Expand Down

0 comments on commit 5e7790e

Please sign in to comment.