Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/show total pages #23 #54

Closed
wants to merge 7 commits into from
Closed

Conversation

pavelthq
Copy link
Collaborator

@pavelthq pavelthq commented Nov 4, 2015

Checked jquery, minimal workable 1.8.1[see my comment in] #55
Implemented #23.

Not any text can be used with variables {{page}}, or {{total_pages}}

So for feature #23 only needed last: '[{{total_pages}}]'

@pavelthq
Copy link
Collaborator Author

pavelthq commented Nov 4, 2015

@esimakin, Done #23.

Also checked jquery. Really minimal workable is 1.8.1 #55

@pavelthq
Copy link
Collaborator Author

pavelthq commented Nov 4, 2015

@esimakin , once you will review I can merge & tag & release.

@pavelthq
Copy link
Collaborator Author

pavelthq commented Nov 4, 2015

Also side note that hrefVarible is no longer supported. it moved/changed to pageVariable.- and default {{number}} changed to {{page}}

@eugenesimakin
Copy link
Collaborator

I need to preview (how it looks like on live) the total pages.
Can you create branch for it? (based on gh-pages branch)

pavelthq added a commit that referenced this pull request Nov 6, 2015
@pavelthq
Copy link
Collaborator Author

pavelthq commented Nov 6, 2015

@esimakin , done. branch gh-pages-example-show-total-pages

@pavelthq
Copy link
Collaborator Author

pavelthq commented Nov 6, 2015

Also I have idea for {{next_page}}, {{prev_page}} variables. But this can be done separately.

@eugenesimakin
Copy link
Collaborator

At my opinion there exist two approach (from point UI view):
First -
screenshot from 2015-11-07 21-09-44
Second -
screenshot from 2015-11-07 21-11-43

This plugin supports first approach.

Are you sure that we do this improvement? It is necessary to support hybrid view?

screenshot from 2015-11-07 21-00-54

@eugenesimakin
Copy link
Collaborator

TODO: make page number customizable through javascript function. For e.g.

pageText: function(pageNumber, pageText) {
   ...
    return newPageText; 
}

@pavelthq
Copy link
Collaborator Author

pavelthq commented Nov 7, 2015

@esimakin , I think supporting hybrid view is not bad, it is requested in #23 . Also you can only modify last: '[{{total_pages}}]' and user will se:
first prev 1 2 3 4 5 next [10]
this functionality is requested so I just implemented.

p.s. as about function for text this can help to introduce second approach that you write.

@smartcorestudio
Copy link

Second or hybrid approach is better, it's more informative because users can see total number of pages

pavelthq added a commit that referenced this pull request Nov 7, 2015
@eugenesimakin
Copy link
Collaborator

Ok, it may look like
screenshot from 2015-11-07 22-09-48

I'll merge it into develop branch

@eugenesimakin
Copy link
Collaborator

Pull request has been merged into develop

@eugenesimakin eugenesimakin deleted the feature/show-total-pages-#23 branch November 7, 2015 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants