-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/show total pages #23 #54
Conversation
@esimakin , once you will review I can merge & tag & release. |
Also side note that hrefVarible is no longer supported. it moved/changed to pageVariable.- and default {{number}} changed to {{page}} |
I need to preview (how it looks like on live) the total pages. |
@esimakin , done. branch gh-pages-example-show-total-pages |
Also I have idea for {{next_page}}, {{prev_page}} variables. But this can be done separately. |
TODO: make page number customizable through javascript function. For e.g. pageText: function(pageNumber, pageText) {
...
return newPageText;
} |
@esimakin , I think supporting hybrid view is not bad, it is requested in #23 . Also you can only modify last: '[{{total_pages}}]' and user will se: p.s. as about function for text this can help to introduce second approach that you write. |
Second or hybrid approach is better, it's more informative because users can see total number of pages |
Pull request has been merged into develop |
Checked jquery, minimal workable 1.8.1[see my comment in] #55Implemented #23.
Not any text can be used with variables {{page}}, or {{total_pages}}
So for feature #23 only needed last: '[{{total_pages}}]'