Merge pull request #35 from simonihmig/immutable-options

Make passed `focusTrapOptions` immutable
josemarluedke · May 26, 2021 · 28e0be4 · 28e0be4
2 parents 4bcb685 + c2760e5
commit 28e0be4
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/addon/modifiers/focus-trap.js b/addon/modifiers/focus-trap.js
@@ -29,7 +29,8 @@ export default setModifierManager(
         },
       }
     ) {
-      state.focusTrapOptions = focusTrapOptions || {};
+      // treat the original focusTrapOptions as immutable, so do a shallow copy here
+      state.focusTrapOptions = { ...focusTrapOptions } || {};
       if (typeof isActive !== 'undefined') {
         state.isActive = isActive;
       }