Fix EAS Build workflow so it builds the requesting PR branch #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🏗 build-android-preview |
…the PR Signed-off-by: Josh Leyshon <[email protected]>
Signed-off-by: Josh Leyshon <[email protected]>
Signed-off-by: Josh Leyshon <[email protected]>
Signed-off-by: Josh Leyshon <[email protected]>
josh-leyshon
force-pushed
the
joosh-fix-eas-build-workflow
branch
from
9a097a3 to
e8fb129
Compare
…rect branch Signed-off-by: Josh Leyshon <[email protected]>
Signed-off-by: Josh Leyshon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows on from #24. The workflow could be run (see comment and build), but would build
masterbranch instead of the PR branch the comment came from. There would be no indication on the PR that the workflow was running.This PR should fix that.
Roughly followed this guide: https://dev.to/zirkelc/trigger-github-workflow-for-comment-on-pull-request-45l2
Uses two Github Action containers:
Unfortunately, the
issue_commentworkflow trigger only works when the workflow file is on the default branch (master). That means that I can't test these changes until I merge this PR tomaster, and then leave a comment on a different PR.